Closed Bug 112273 Opened 23 years ago Closed 23 years ago

Inconsistent chrome URL in Classic 's global/content.rdf

Categories

(SeaMonkey :: Themes, defect)

Product:
SeaMonkey
Component:
Themes
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.9

People

(Reporter: dolmen, Assigned: shliang)

References

(
URL
)

Details

Attachments

(1 file, 2 obsolete files)

changing to just preview.gif
1.64 KB, patch
andreww
: review+
hewitt
: superreview+
Details | Diff | Splinter Review
From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9.6) Gecko/20011120 BuildID: 2001112009 (Mozilla release 0.9.6) In the file skin/classic/global/content.rdf in classic.jar line 18, there is a minor inconsitency : The line is : chrome:image="jar:resource:///chrome/classic.jar!/skin/classic/global/preview.gif"> It should be : chrome:image="jar:resource:/chrome/classic.jar!/skin/classic/global/preview.gif"> Note the three slashes instead of only one in the other chrome URL of the file.
Status: UNCONFIRMED → NEW
Ever confirmed: true
-> shliang
Assignee: hewitt → shliang
Attached patch changes to contents.rdf (obsolete) — — Splinter Review
Attached patch changes to contents.rdf (obsolete) — — Splinter Review
Comment on attachment 65360 [details] [diff] [review] changes to contents.rdf sr=hewitt
Attachment #65360 - Flags: superreview+
The patch is ok.
Target Milestone: --- → mozilla0.9.9
Andrew-can you review this patch for Shuehan?
Status: NEW → ASSIGNED
looks ok, but why is it that in modern skin there's no reference to the jar file? see this line: http://lxr.mozilla.org/seamonkey/source/themes/modern/global/contents.r df#18 compared to : http://lxr.mozilla.org/seamonkey/source/themes/classic/global/win/content s.rdf#18 either modern is incorrect as well, or classic should match modern... or is there some other factor here?
andrew, could you review? thanks.
Attachment #65359 - Attachment is obsolete: true
Attachment #65360 - Attachment is obsolete: true
Comment on attachment 68917 [details] [diff] [review] changing to just preview.gif sr=hewitt
Attachment #68917 - Flags: superreview+
Keywords: nsbeta1+
Comment on attachment 68917 [details] [diff] [review] changing to just preview.gif r=andreww
Attachment #68917 - Flags: review+
fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Verified the patch.
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: