1122751 - bumper bot needs to populate git information in gaia.json

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

Attachment: Populate git information in gaia.json

If we're going to be checking out gaia from git, we need to know the git revision to use.

Comment 1

[Pete Moore [:pmoore][:pete]]

Comment on attachment 8550546 [details] [diff] [review]
Populate git information in gaia.json

Review of attachment 8550546 [details] [diff] [review]:
-----------------------------------------------------------------

The change looks very good, and should cut down on traffic to mapper. Thanks for doing this!

Pete

::: configs/b2g_bumper/master.py
@@ +24,5 @@
>      'gaia_revision_file': 'b2g/config/gaia.json',
>      'gaia_max_revisions': 5,
>      # Which git branch this hg repo corresponds to
>      'gaia_git_branch': 'master',
> +    'gaia_git_repo': 'https://git.mozilla.org/releases/gaia.git',

do we also need this config entry for the other branches than master?

Comment 2

[Chris AtLee [:catlee]]

Hmm, yes, most likely. Let's turn this on for master first?

Comment 3

[Pete Moore [:pmoore][:pete]]

OK, why not. Can you send me another r? if you like for the other branches after we're happy it is working ok on master.

Comment 4

[Pete Moore [:pmoore][:pete]]

s/Can you/You can/

Typing too quickly today! =)

Comment 5

[Chris Cooper [:coop] (he/him)]

In production: https://hg.mozilla.org/build/mozharness/rev/31fec8b877fd

Comment 6

[Chris AtLee [:catlee]]

Attachment: configs for other branches

Comment 7

[Jordan Lund (:jlund)]

Comment on attachment 8551894 [details] [diff] [review]
configs for other branches

Review of attachment 8551894 [details] [diff] [review]:
-----------------------------------------------------------------

bumper is not happy. complaining about missing key from this patch:

815 13:13:37    FATAL - Uncaught exception: Traceback (most recent call last):
816 13:13:37    FATAL -   File "/builds/b2g_bumper/mozharness/mozharness/base/script.py", line 1277, in run
817 13:13:37    FATAL -     self.run_action(action)
818 13:13:37    FATAL -   File "/builds/b2g_bumper/mozharness/mozharness/base/script.py", line 1219, in run_action
819 13:13:37    FATAL -     self._possibly_run_method(method_name, error_if_missing=True)
820 13:13:37    FATAL -   File "/builds/b2g_bumper/mozharness/mozharness/base/script.py", line 1160, in _possibly_run_method
821 13:13:37    FATAL -     return getattr(self, method_name)()
822 13:13:37    FATAL -   File "/builds/b2g_bumper/mozharness/scripts/b2g_bumper.py", line 602, in push_loop
823 13:13:37    FATAL -     if not self.config.get('skip_gaia_json') and self.bump_gaia():
824 13:13:37    FATAL -   File "/builds/b2g_bumper/mozharness/scripts/b2g_bumper.py", line 574, in bump_gaia
825 13:13:37    FATAL -     git_gaia_repo = self.config['gaia_git_repo']

Comment 8

[Jordan Lund (:jlund)]

Comment on attachment 8551894 [details] [diff] [review]
configs for other branches

live in production: https://hg.mozilla.org/build/mozharness/rev/0d2d12b3051a

Comment 9

[Pete Moore [:pmoore][:pete]]

Thanks Jordan for sorting this out!

Comment 10

[Armen [:armenzg]]

https://hg.mozilla.org/build/ash-mozharness/rev/6a53c67fbe22