Closed
Bug 1122772
Opened 9 years ago
Closed 9 years ago
Remove the code used to support unified builds from mozharness; r=bhearsum
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
11.29 KB,
patch
|
jlund
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8550577 -
Flags: review?(bhearsum)
Comment 2•9 years ago
|
||
Comment on attachment 8550577 [details] [diff] [review] Remove the code used to support unified builds from mozharness Review of attachment 8550577 [details] [diff] [review]: ----------------------------------------------------------------- I'm going to defer to Jordan on this one. Names like "64_debug_and_non_unified" make me unsure whether or not they're safe to remove.
Attachment #8550577 -
Flags: review?(bhearsum) → review?(jlund)
Comment 3•9 years ago
|
||
Comment on attachment 8550577 [details] [diff] [review] Remove the code used to support unified builds from mozharness Review of attachment 8550577 [details] [diff] [review]: ----------------------------------------------------------------- IIUC, this is fine. the old buildbot way we created nonunified in buildbotcustom based on whether the platform had 'enable_nonunified_build':True from buildbot-configs. Both opt and debug platforms did nonunified so I needed a config file for the basic nonunified (64_non_unified.py) and the debug_nonunified (64_debug_and_non_unified).
Attachment #8550577 -
Flags: review?(jlund) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/build/mozharness/rev/af1461521190
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 5•9 years ago
|
||
In production: https://hg.mozilla.org/build/mozharness/rev/af1461521190
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•