Turn on treeherder staging integration for in tree gecko integration...

RESOLVED FIXED

Status

Taskcluster
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: lightsofapollo, Assigned: lightsofapollo)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8550593 [details]
MozReview Request: bz://1122774/lightsofapollo
Attachment #8550593 - Flags: review?(garndt)
(Assignee)

Comment 2

3 years ago
/r/2633 - Bug 1122774 - Add treeherder integration r=garndt

Pull down this commit:

hg pull review -r f199796f8ee9c2130a3d166ac68bcc9f0aafe5df

Comment 3

3 years ago
https://reviewboard.mozilla.org/r/2633/#review1819

::: testing/taskcluster/mach_commands.py
(Diff revision 1)
> +                    if 'treeherder' not in test_task['task']['extra']:

Is there a scenario where treeherder wouldn't be defined in a test task's extra info?  It's assumed to be defined in the build task above, but isn't necessary for a test task and we default to an empty dict.

Also, if treeherder is not defined in the task's 'extra', there might not be an extra at all and this would fail with a key error I think.

::: testing/taskcluster/tasks/decision/branch.yml
(Diff revision 1)
> -          GECKO_HEAD_REPOSITORY: '{{repository_url}}'
> +          GECKO_HEAD_REPOSITORY: '{{url}}'

Looks like we'll need to update the mach command for decision graph to pass in the right name.

Comment 4

3 years ago
Comment on attachment 8550593 [details]
MozReview Request: bz://1122774/lightsofapollo

r+ with a couple of comments in the review
Attachment #8550593 - Flags: review?(garndt) → review+
https://hg.mozilla.org/mozilla-central/rev/aaec6c627ea3
Assignee: nobody → jlal
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
(Assignee)

Comment 6

3 years ago
Comment on attachment 8550593 [details]
MozReview Request: bz://1122774/lightsofapollo
Attachment #8550593 - Attachment is obsolete: true
Attachment #8619170 - Flags: review+
(Assignee)

Comment 7

3 years ago
Created attachment 8619170 [details]
MozReview Request: Bug 1122774 - Add treeherder integration r=garndt
Component: TaskCluster → General
Product: Testing → Taskcluster
Target Milestone: mozilla38 → mozilla41
Version: unspecified → Trunk
Resetting Version and Target Milestone that accidentally got changed...
Target Milestone: mozilla41 → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.