1122790 - Adjust FxA authorize module to let the caller manage popup window

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P1)

Description

[Kumar McMillan [:kumar]]

On the desktop payments flow, the FxA login and pay flow need to share the same popup window otherwise things get hairy (see bug 1122243). Gory details: https://etherpad.mozilla.org/fireplace-pay-popup-madness

This bug is to move window.close() from views/fxa_authorize [1] to the handle_fxa_login func in login.js [2] this will put the window closing control with the opener instead of with the popup.

[1] https://github.com/mozilla/marketplace-core-modules/blob/5b4dc7b3c8ca75cbaddd88ae98ab3f173529d35a/views/fxa_authorize.js#L30
[2] https://github.com/mozilla/marketplace-core-modules/blob/master/login.js#L256

Comment 1

[[e-mail]]

https://github.com/mozilla/fireplace/commit/a2fbb1e8fe5dd2deb3bd1fae3b04eaf635dea476
https://github.com/mozilla/marketplace-core-modules/commit/01833d303a051701e743ff5c7a554daed311abe0

QA Steps: 

These steps cover both this bug and bug 1122792

The old popup handling for payments opens 2 popups. The payments window was opened in advance and then the login window opens in front of it.

These changes re-use the login popup for payments. This means there's a single popup and the flow is a lot less clunky as a result.

* Starting logged out
* Search :paid
* A single popup window opens for login
* sign-in 
* The sign-in window is then resized and becomes the payment flow.

Comment 2

[[e-mail]]

In fact we can probably ignore the QA steps as these flows are to be tested together as part of the overall desktop payments QA.