Closed Bug 1122820 Opened 9 years ago Closed 9 years ago

[Camera] While USB Storage is enabled, user can enter Camera and tap 'Shutter' before "No Access" UI is present; can stall flash on

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.0 affected, b2g-v2.1 affected, b2g-v2.2 affected, b2g-master verified)

VERIFIED FIXED
Tracking Status
b2g-v2.0 --- affected
b2g-v2.1 --- affected
b2g-v2.2 --- affected
b2g-master --- verified

People

(Reporter: onelson, Assigned: wilsonpage)

References

()

Details

(Whiteboard: [3.0-Daily-Testing])

Attachments

(3 files)

Description:
When the user has USB Storage enabled on their device, they lose access to a handful of media applications (Gallery, Video, Camera) until the USB is removed. Upon opening Camera, the user is confronted with a blocking UI screen that informs to remove USB in order to operate. However, upon open of the app, the camera will load before the UI and the user may tap the shutter button and trigger the flash momentarily. In 1/4 of the attempts, the shutter sound is made. The photo is not taken.
This issue only occurs on an inital load of the camera application while plugged in, where loading the camera takes priority over loading the system message: if the camera app is already open when accessed with USB attached, the user will run into the system message before the Camera UI.
   
Repro Steps:
1) Update a Flame device to BuildID: 20150116010205
2) Open the 'Settings' app.
3) Enable 'USB Storage'.
4) Connect to computer via USB cable.
5) Navigate to 'Camera' app.
6) Tap 'Shutter' button as it loads to attempt to capture photo before 'USB Attached' UI appears.
  
Actual:
Shutter begins to interact with Camera and flash is turned on. User is locked by USB UI from proceeding.
  
Expected: 
USB UI loads before Camera becomes available.
  
Environmental Variables:
Device: Flame 3.0 Master
BuildID: 20150116010205
Gaia: 401e981f51cf047292d101c785be8ec48bf75e8c
Gecko: cac6192956ab
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 38.0a1 (3.0 Master)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
  
  
Repro frequency: 20/20
See attached: 
video- http://youtu.be/UDrbVyWyeE4
logcat
This issue REPROES on flame 2.2, 2.1 and 2.0 devices:
Results: Shutter begins to interact with Camera and flash is turned on momentarily. User is locked by USB UI from proceeding. No photo is taken.

Environmental Variables:
----------------------------------------------
Device: Flame 2.2
BuildID: 20150116002502
Gaia: 2f916cdba7305b51a72482b6bfe860c5b8924f9c
Gecko: b4c7c83a44a5
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a2 (2.2)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 2.1
BuildID: 20150116001340
Gaia: 230a9c5303e2113f7dbcaf431441ae2138853141
Gecko: e43e97795f5d
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 34.0 (2.1)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.0
BuildID: 20150116000204
Gaia: 736933b25ded904f0cb935a0d48f1f3cf91d33ad
Gecko: 3859056ba366
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 32.0 (2.0)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
----------------------------------------------
Repro: 5/5
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Whiteboard: [2.1-Daily-Testing]
Wilson, can we keep the shutter button disabled until we confirm we have file system access?
Flags: needinfo?(wilsonpage)
Flags: needinfo?(ktucker)
Whiteboard: [2.1-Daily-Testing] → [3.0-Daily-Testing]
Not nominating to block on this since it is not a regression and the user can take photos without issue once unplugging the device from the computer.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Attached file pull-request (master)
CAUSE:

The controls get enabled when they hear the app 'loaded' event. This previously depended on just the loading of our 'lazy' modules. This meant that the controls were being enabled before the storage check was complete.

FIX:

This patch now additionally waits for the storage check to complete before firing the 'loaded' event, meaning controls won't be enabled before the overlay is visible.
Flags: needinfo?(wilsonpage)
Attachment #8552413 - Flags: review?(jdarcangelo)
Comment on attachment 8552413 [details] [review]
pull-request (master)

Wilson: I have posted a question in GitHub.
Attachment #8552413 - Flags: review?(jdarcangelo) → review+
Assignee: nobody → wilsonpage
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
This bug has been verified as "pass" on the latest nightly build of Flame KK 2.5 by the STR in comment 0.

Actual results: The shutter button is disabled when user enables USB storage and plugs in USB cable with computer.
See attachment: verified_FlameKK_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150827150209
Gaia Revision          d784c81961d82cbe9e111405468c590a8345856c
Gaia Date              2015-08-27 12:29:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ca086f9ef8bca2d6cdfa79bfc4c854f56a59859e
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150827.190412
Firmware Date          Thu Aug 27 19:04:26 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][MGSEI-Triage+]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: