112287 - MLK: leaking url in mime when forwarding inline

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect)

Description

[Navin Gupta]

[W] MLK: Memory leak of 164 bytes from 1 block allocated in 
nsStandardURLConstructor
        Distribution of leaked blocks
        Allocation location
        new(UINT)      [new.cpp:23]
        nsStandardURLConstructor [nsNetModule.cpp:134]
                nsGenericFactory::CreateInstance(nsISupports *,nsID const&,void 
* *) [nsGenericFactory.cpp:74]
                nsComponentManagerImpl::CreateInstance(nsID const&,nsISupports 
*,nsID const&,void * *) [nsComponentManager.cpp:1559]
                nsComponentManager::CreateInstance(nsID const&,nsISupports 
*,nsID const&,void * *) [nsComponentManager.cpp:3330]
                nsFileProtocolHandler::NewURI(char const*,nsIURI *,nsIURI * *) 
[nsFileProtocolHandler.cpp:134]
                nsIOService::NewURI(char const*,nsIURI *,nsIURI * *) 
[nsIOService.cpp:745]
                        }
                        if (NS_FAILED(rv)) return rv;
                    
                 =>     return handler->NewURI(aSpec, base, result);
                    }
                    
                    
                nsMimeNewURI   [mimemoz2.cpp:631]
                      if (NS_FAILED(res))
                        return NS_ERROR_FACTORY_NOT_REGISTERED;
                    
                 =>   return pService->NewURI(aSpec, aBase, aInstancePtrResult);
                    }
                    
                    extern "C" nsresult
                mime_decompose_file_init_fn(void *,MimeHeaders *) 
[mimedrft.cpp:1850]
                      if (tmpSpec)
                      {
                          nsFileURL fileURL(*tmpSpec);
                 =>       const char * tempSpecStr = fileURL.GetURLString();
                    
                          nsMimeNewURI(&(newAttachment->orig_url), tempSpecStr, 
nsnull);
                          NS_IF_ADDREF(newAttachment->orig_url);
                MimeMessage_add_child [mimemsg.cpp:603]
                        int status = 0;
                        status = parent->options->decompose_file_init_fn (
                                                                  
parent->options->stream_closure,
                 =>                                               
((MimeMessage*)parent)->hdrs );
                        if ( status < 0 ) return status;
                      }
                    #endif /* MIME_DRAFTS */

Comment 1

[Navin Gupta]

Attachment: proposed fix

use nsCOMPtr to avoid explicit addref and release. here it is being addref'ed
twice.

Comment 2

[Navin Gupta]

cc ducarroz and bienvenu for review

Comment 3

[David :Bienvenu]

Comment on attachment 59446 [details] [diff] [review]
proposed fix

+ if (a[i].orig_url)
+ a[i].orig_url=nsnull;
should just be a[i].orig_url=nsnull, no need to check if it's null before.
Also, it seems like there might be tabs in your diff. Fix those things, and
sr=bienvenu

Comment 4

[Jean-Francois Ducarroz]

Comment on attachment 59446 [details] [diff] [review]
proposed fix

don't need to test orig_url before setting it to null (3 occurrences). Appart
that, R=ducarroz

Comment 5

[Navin Gupta]

fixed

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED using the latest trunk build on Windows 2000 / Purify.