1122913 - Remove object out-parameter from native LookupOwnProperty

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom S [:evilpie]]

Attachment: remove-objp

Comment 1

[Jason Orendorff [:jorendorff]]

Comment on attachment 8550716 [details] [diff] [review]
remove-objp

Review of attachment 8550716 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!

::: js/src/jsobj.cpp
@@ +2933,5 @@
>          if (!done) {
>              objp.set(nullptr);
>              propp.set(nullptr);
>              return true;
> +        } else {

Style nit: No else after return.

::: js/src/vm/NativeObject-inl.h
@@ +427,3 @@
>       * cx->resolvingTable, control must go through cleanup: before
>       * returning.  But note that JS_DHASH_ADD may find an existing
>       * entry, in which case we bail to suppress runaway recursion.

While you're fixing comments, note that there is no `cleanup:` label anymore. The whole second paragraph here can be removed, I think.

Comment 2

[Tom S [:evilpie]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d98309db7e20

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d98309db7e20