All users were logged out of Bugzilla on October 13th, 2018

Remove object out-parameter from native LookupOwnProperty

RESOLVED FIXED in mozilla38

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

(Blocks: 1 bug)

Trunk
mozilla38
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8550716 [details] [diff] [review]
remove-objp
Attachment #8550716 - Flags: review?(jorendorff)
(Assignee)

Updated

4 years ago
Assignee: nobody → evilpies
Comment on attachment 8550716 [details] [diff] [review]
remove-objp

Review of attachment 8550716 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!

::: js/src/jsobj.cpp
@@ +2933,5 @@
>          if (!done) {
>              objp.set(nullptr);
>              propp.set(nullptr);
>              return true;
> +        } else {

Style nit: No else after return.

::: js/src/vm/NativeObject-inl.h
@@ +427,3 @@
>       * cx->resolvingTable, control must go through cleanup: before
>       * returning.  But note that JS_DHASH_ADD may find an existing
>       * entry, in which case we bail to suppress runaway recursion.

While you're fixing comments, note that there is no `cleanup:` label anymore. The whole second paragraph here can be removed, I think.
Attachment #8550716 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/d98309db7e20
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.