Closed Bug 1122955 Opened 9 years ago Closed 7 years ago

typo in addon-sdk/.../tabs-fennec.js

Categories

(Add-on SDK Graveyard :: General, defect)

All
Android
defect
Not set
major

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: m_khvoinitsky, Unassigned)

References

Details

There is a typo in file mozilla-central/source/addon-sdk/source/lib/sdk/windows/tabs-fennec.js (line "for (let of in gTabs) {" instead of "for (let of t gTabs) {").
It was fixed in upstream (addon-sdk repo on github). But fix still not in mozilla-central (bug https://bugzilla.mozilla.org/show_bug.cgi?id=1114752 ). And the version with typo now in beta.

It breaks many SDK addons for android (One of my addon users reported me that the addon stopped working in Firefox Beta for Android from Google Play).
Version: unspecified → 36 Branch
Product: Firefox → Add-on SDK
Version: 36 Branch → unspecified
Erik, do you know what's going on here?
Flags: needinfo?(evold)
So this (In reply to :Gijs Kruitbosch from comment #1)
> Erik, do you know what's going on here?

This regression was introduced in bug 866733 which was merged on July 19, 2014, and fixed in bug 1102504.  I'm tempted to make this a dup of bug 1102504.  It's unfortunate that we haven't gotten this fix uplifted yet, but we should soon.

We previously noticed Fennec test issues, and decided that we need support/priority/interest from Fennec/Platform teams first (ref https://wiki.mozilla.org/Jetpack/Weekly_Meeting/2014-05-06).

We have bug 809143 open for getting our tests running on Fennec.
Flags: needinfo?(evold)
Priority: -- → P1
Correct variant: "(let t of gTabs)" as in master on github. My 1st comment contains mistake.
Priority: P1 → --
https://bugzilla.mozilla.org/show_bug.cgi?id=1399562
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.