Closed
Bug 1122987
Opened 9 years ago
Closed 9 years ago
Mark nsPIDOMWindow::mInnerWindow as non-owning; r=smaug
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
1.19 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
The inner window holds an owning reference to its outer window, and the outer window holds a non-owning reference back to its inner window. The non-owning reference is managed by nsGlobalWindow.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ehsan
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8550793 -
Flags: review?(bugs)
Comment 2•9 years ago
|
||
Comment on attachment 8550793 [details] [diff] [review] Mark nsPIDOMWindow::mInnerWindow as non-owning I guess in this case not using _UNSAFE is fine, since the inner window keeps outer alive, and mOuterWindow is cleared only in dtor and unlink and in both cases MaybeClearInnerWindow is called.
Attachment #8550793 -
Flags: review?(bugs) → review+
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/63f9aed866c0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•