Mark nsPropertiesParser as stack class, and make its mProps member a strong ref; r=froydnj

RESOLVED FIXED in mozilla38

Status

()

Core
XPCOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

(Blocks: 1 bug)

unspecified
mozilla38
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

3 years ago
Assignee: nobody → ehsan
Blocks: 1114683
(Assignee)

Comment 1

3 years ago
Created attachment 8550796 [details] [diff] [review]
Mark nsPropertiesParser as stack class, and make its mProps member a strong ref
Attachment #8550796 - Flags: review?(nfroyd)
Comment on attachment 8550796 [details] [diff] [review]
Mark nsPropertiesParser as stack class, and make its mProps member a strong ref

Review of attachment 8550796 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/ds/nsPersistentProperties.cpp
@@ +176,5 @@
>                                  // escaped whitespaces
>    EParserState mState;
>    // if we see a '\' then we enter this special state
>    EParserSpecial mSpecialState;
> +  nsCOMPtr<nsIPersistentProperties> mProps;

I dunno, in some ways it would be better to reorganize the code so that we didn't have to take a reference here, but meh.
Attachment #8550796 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/d6161c63e250
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.