1122991 - Mark findIndexOfClosure as stack class, and make its targetElement member a strong ref; r=froydnj

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[(no longer active)]

Attachment: Mark findIndexOfClosure as stack class, and make its targetElement member a strong ref

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8550797 [details] [diff] [review]
Mark findIndexOfClosure as stack class, and make its targetElement member a strong ref

Review of attachment 8550797 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but I think the strong-refness is just unnecessary work in this case.

::: xpcom/ds/nsArray.cpp
@@ +14,2 @@
>  {
> +  nsCOMPtr<nsISupports> targetElement;

Can't IndexOf() just assume that somebody else is holding references to the element?

Comment 3

[(no longer active)]

I can do something better in fact!  Since this is just used for pointer comparison, I'll convert it to a void*!

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/df5fad5e386d