1122995 - Clarify the lifetime rules applying to the permanent and non-permanent nsIATOM* members in nsAtomTable.cpp; r=froydnj

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[(no longer active)]

Attachment: Clarify the lifetime rules applying to the permanent and non-permanent nsIATOM* members in nsAtomTable.cpp

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8550799 [details] [diff] [review]
Clarify the lifetime rules applying to the permanent and non-permanent nsIATOM* members in nsAtomTable.cpp

Review of attachment 8550799 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with a suitable answer to the below question.

::: xpcom/ds/nsAtomTable.cpp
@@ +171,5 @@
>    }
> +
> +private:
> +  NS_IMETHOD_(MozExternalRefCountType) AddRef();
> +  NS_IMETHOD_(MozExternalRefCountType) Release();

I don't know that this change really accomplishes anything, and is slightly confusing (though [class.access.virt] explicitly covers this sort of thing).  What's the rationale for doing this?

Comment 3

[(no longer active)]

Just trying to make it impossible to call AddRef/Release on concrete PermanentAtomImpl types (I know that this won't disallow virtual dispatch, but it's the best we can do here.  FWIW I believe these functions _will_ be called at runtime through virtual dispatch, but their implementation makes that OK.)

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4a3d85dc67fc