1123003 - Clarify the ownership of xptiInterfaceInfo pointers in xptiprivate.h; r=froydnj

Status: RESOLVED FIXED

Description

[Away for a while]

Comment 1

[Away for a while]

Created attachment 8550809 [details] [diff] [review]
Clarify the ownership of xptiInterfaceInfo pointers in xptiprivate.h

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8550809 [details] [diff] [review]
Clarify the ownership of xptiInterfaceInfo pointers in xptiprivate.h

Review of attachment 8550809 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/reflect/xptinfo/xptiInterfaceInfo.cpp
@@ -689,4 @@
>                   !mParent &&
>                   mEntry->Parent(),
>                  "bad BuildParent call");
> -    mParent = mEntry->Parent()->InterfaceInfo().take();

Ha!

::: xpcom/reflect/xptinfo/xptiprivate.h
@@ +304,5 @@
>  
>      xptiInterfaceEntry*     mParent;      // Valid only when fully resolved
>  
> +    xptiInterfaceInfo* MOZ_UNSAFE_REF("The safety of this pointer is ensured "
> +                                      "by the semantics of XPTIWorkingSet.")

xptiWorkingSet, please, so grep can find it easily.

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b8f271c913a9