Closed
Bug 1123006
Opened 9 years ago
Closed 9 years ago
Mark FileData as stack class, and its data member as nsCOMPtr; r=froydnj
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
|
3.21 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ehsan
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8550812 -
Flags: review?(nfroyd)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8550812 [details] [diff] [review] Mark FileData as stack class, and its data member as nsCOMPtr Review of attachment 8550812 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/io/nsDirectoryService.cpp @@ +328,5 @@ > if (aData->data) { > nsCOMPtr<nsISimpleEnumerator> unionFiles; > > NS_NewUnionEnumerator(getter_AddRefs(unionFiles), > + (nsISimpleEnumerator*)aData->data.get(), newFiles); All the casting going on here is very dodgy.
Attachment #8550812 -
Flags: review?(nfroyd) → review+
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a5de50c69a8d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•