1123069 - [hamachi] Not possible to open link located on horizontal swipe carousel

Status: RESOLVED WONTFIX

(Web Compatibility :: Site Reports, defect, P5)

Description

[mac]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20150108202552

Steps to reproduce:

1. Open mobile version of gsmarena.com (same on m.interia.pl)
2. Page should open on Home seciton with carousel with news on the bottom.
3. It is possible to go through 6 news on the carousel.


Actual results:

Not possible to open any of news from the horizontal carousel as shown on the yt video:

https://www.youtube.com/watch?v=pcUmfE_TvzY


Expected results:

It should be possible to open link which is located on horizontal swipe carousel.

Comment 1

[mac]

Found on:

Alcatel One Touch Fire production (got from T-mobile Poland)
B2G version: 3.0.0.0-prerelease master
Platform version: 38.0a1
Build Identifier: 2015015010229
Git commit info: 2015-01-16 22:12:30 0f65b258

Comment 2

[u495161]

Same on
Alcatel One Touch Fire production (got from T-mobile Poland)
B2G version: 3.0.0.0-prerelease master
Platform version: 38.0a1
Build Identifier: 20150118010206
Git commit info: 2015-01-16 22:12:30 0f65b258

By the way, if I remember well, that was also on B2G 2.2 and (I'm not sure about this) on 2.1

Comment 3

[mac]

The issue exists from the time when old Browser was replaced by the new one. b2g 2.0 was the last version on which the scenario worked properly.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

I can repro on Hamachi but not Flame. I'll investigate, parking with me for now.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Seems like the webpage is doing a preventDefault on the first touchmove, which prevents the tap gesture from being detected. On hamachi the first touchmove coordinates are at the same point as the touchstart so it's technically not a "move". I haven't checked on Flame yet but if my memory serves I think on Flame we wouldn't be sending that touchmove at all, and so the webpage wouldn't preventDefault it, and the tap would get detected.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Website JS code being used

The website is using an old version of swipe.js [1], which has the attached touchstart and touchmove listeners. Note in particular that the code will detect a horizontal scroll even if deltaX and deltaY are both 0 on the first touchmove, which is exactly what is happening here. The latest version of swipe [2] appears to have the same problem. I think this is badness in the JS code; most JS libraries that attempt to do similar things ensure that they allow some slop for the finger to move before attempting to detect the direction. As it is code like this defeats the allowed slop in our APZ code and will make it much harder to tap things (if your finger wiggles even a tiny bit between touchdown and touchup it will misinterpret it).

[1] http://cdn2.gsmarena.com/w/m/js/swipe.js
[2] https://github.com/thebird/Swipe/blob/master/swipe.js#L302

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Moving to Tech Evangelism since I think the website/libraries should be updated in this case.

Comment 8

[Hallvord R. M. Steen [:hallvors]]

Seems this is well understood, marking contactready. But is this working better in other browsers?

Comment 9

[mac]

Same situation in Facebook app on hamachi. If you log in to Facebook, go to Friends section then on the top you will also have carousel with links and it also doesn't work.

Comment 10

[Karl Dubost💡 :karlcow]

désolé, wrong move.

Comment 11

[Karl Dubost💡 :karlcow]

The Firefox OS project is not active anymore.