1123110 - Clarify the ownership of several cycle collector members; r=smaug

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[(no longer active)]

Attachment: Clarify the ownership of several cycle collector members

Comment 2

[Andrew McCreight [:mccr8]]

Comment on attachment 8550945 [details] [diff] [review]
Clarify the ownership of several cycle collector members

Review of attachment 8550945 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: xpcom/base/nsCycleCollector.cpp
@@ +1256,5 @@
>    CCGraph mGraph;
>    nsAutoPtr<CCGraphBuilder> mBuilder;
>    nsCOMPtr<nsICycleCollectorListener> mListener;
>  
> +  nsCOMPtr<nsIThread> mThread;

This could be made DebugOnly<void*> or void*, as we only compare it with pointers.

@@ +1270,5 @@
>  
>    uint32_t mUnmergedNeeded;
>    uint32_t mMergedInARow;
>  
> +  JSPurpleBuffer* MOZ_OWNING_REF mJSPurpleBuffer;

This could probably be an nsRefPtr<JSPurpleBuffer>.  You'd just have to change the ctor of JSPurpleBuffer and JSPurpleBuffer::mReferenceToThis to an nsRefPtr<>.  Then you could ditch the NS_ADDREF/RELEASE_THIS in JSPurpleBuffer.  If you don't want to do that, I guess I can file a followup bug.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

There was some reason for the unusual addref/release_this...
But if we can use nsRefPtr there, good.

Comment 4

[(no longer active)]

Consider it done!

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7e6b191f83f7