1123115 - Clarify the ownership of some member variables in task.h; r=smaug

Status: RESOLVED FIXED

(Core :: IPC, defect)

Comment 1

[(no longer active)]

Attachment: Clarify the ownership of some member variables in task.h

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8550951 [details] [diff] [review]
Clarify the ownership of some member variables in task.h

Review of attachment 8550951 [details] [diff] [review]:
-----------------------------------------------------------------

I hate this task stuff...

::: ipc/chromium/src/base/task.h
@@ +196,5 @@
>  
>      virtual void Run() { DispatchToMethod(obj_, meth_, params_); }
>  
>     private:
> +    T* MOZ_UNSAFE_REF("The validity of this pointer must be enforced by "

A better way to say this is "We have no idea if this is safe!" ;)

Comment 3

[(no longer active)]

(In reply to ben turner [:bent] (use the needinfo? flag!) from comment #2)
> ::: ipc/chromium/src/base/task.h
> @@ +196,5 @@
> >  
> >      virtual void Run() { DispatchToMethod(obj_, meth_, params_); }
> >  
> >     private:
> > +    T* MOZ_UNSAFE_REF("The validity of this pointer must be enforced by "
> 
> A better way to say this is "We have no idea if this is safe!" ;)

I know right? :(

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/69cdf42cdaf9