Closed
Bug 1123174
Opened 11 years ago
Closed 11 years ago
[Stingray] jshint failure in tv dlna-player
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chens, Assigned: chens)
References
Details
(Whiteboard: [ft:conndevices][ETA:1/23])
Attachments
(1 file)
We have to fix jshint failures to prevent code breaking in tv's dlna-browser
|
Assignee | |
Updated•11 years ago
|
|
||
Updated•11 years ago
|
Whiteboard: [ft:conndevices][ETA:1/23]
|
|
Assignee | |
Updated•11 years ago
|
Summary: [Stingray] jshint failure in tv dlna-browser → [Stingray] jshint failure in tv dlna-player
|
|
Assignee | |
Comment 1•11 years ago
|
||
Hi Rex,
This patch fixes jshint failures in dlna-player, but linter will ignore errors in lib folder, would you review this patch and give some feedback? thanks!
Assignee: nobody → shchen
Attachment #8551073 -
Flags: review?(rexboy)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8551073 [details] [review]
Pull request to master
Looks good to me.
Some undefined variables may need to be cleaned but let's eliminate jshint problems first.
Attachment #8551073 -
Flags: review?(rexboy) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Also cleaned undefined variables and updated PR, but seems treeherder hooks not picking this up.
|
|
Assignee | |
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•