Closed Bug 1123175 Opened 9 years ago Closed 9 years ago

[Stingray] jshint failure in tv smart-home

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: chens, Assigned: chens)

References

Details

(Whiteboard: [ft:conndevices][ETA:1/23])

Attachments

(1 file)

Pull request to master
46 bytes, text/x-github-pull-request
rexboy
: review+
Details | Review 
We to have fix jshint failures to prevent code breaking in tv's smart-home
Blocks: 1120340
No longer depends on: 1120340
Assignee: nobody → shchen
Whiteboard: [ft:conndevices][ETA:1/23]
Attached file Pull request to master — 
Hi Rex,

This patch fixes jshint failures in smart-home, would you review this patch and give some feedback? thanks!
Attachment #8551043 - Flags: review?(rexboy)
Comment on attachment 8551043 [details] [review]
Pull request to master

Looks good to me 

Thanks!
Attachment #8551043 - Flags: review?(rexboy) → review+
(In reply to KM Lee [:rexboy] (Away Dec. 26 ~ Jan. 4) from comment #2)
> Comment on attachment 8551043 [details] [review]
> Pull request to master
> 
> Looks good to me 
> 
> Thanks!

I think "MessageHandler" declaration is necessary to home.js.
Sorry, we modified home.js in stingray and so cannot provide patch but
just add below to tv_apps/smart-home/js/home.js

/* global MessageHandler */
You are right, and we have added |MessageHandler| declaration in this patch[1].

[1]: https://github.com/mozilla-b2g/gaia/pull/27477/files#diff-5a33a94cd737c2a136a3c3139f952015R3
master: https://github.com/mozilla-b2g/gaia/commit/efd2e8d6ccde7451734acc07c8578d670587d0ec
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: