Closed
Bug 1123306
Opened 9 years ago
Closed 9 years ago
Remove minSquaredDistanceBetweenPoints from the LineGraph
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 38
People
(Reporter: vporof, Assigned: vporof)
Details
Attachments
(1 file)
|
10.25 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
This is currently basically disabled (the distance is set to 1px), so it provides minimal to no benefit. Actually, it might make things a little bit slower because of the extra conditional and math done on every point in the data source. I suggest removing this. It can only make a small difference in 10 minute long recordings, and at that point there's other much bigger problems to solve.
|
Assignee | |
Comment 1•9 years ago
|
||
|
||
Updated•9 years ago
|
Attachment #8551265 -
Flags: review?(jsantell) → review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/121f46041aba
Whiteboard: [fixed-in-fx-team]
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/121f46041aba
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•