Closed Bug 1123333 Opened 9 years ago Closed 9 years ago

PLATFORM_ORDER is missing a number of platforms

Categories

(Tree Management :: Treeherder, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

We have the current delightful situation where hardcoded platform names are scattered in a bunch of places:
* ingestion:
https://github.com/mozilla/treeherder-service/blob/master/treeherder/etl/buildbot.py
* in the resultset api:
https://github.com/mozilla/treeherder-service/blob/master/treeherder/webapp/api/resultset.py#L19
* and in the UI:
https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/js/values.js#L7

The second of which is out of sync.

Fwiw bug 1043249 is filed to move the UI mappings into the service. The ingestion-api split is probably unavoidable given buildbot vs non-buildbot.
Blocks: 1119412, 1112693
Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/ef5d699a944a1d4fe4438aa32d139ec61f9c6199
Bug 1123333 - Add missing platforms to PLATFORM_ORDER

Some recently added platforms were added to the ingestion regex and UI
mappings, but not PLATFORM_ORDER - and so are ordered incorrectly in the
API response, and thus Treeherder's UI.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: