Closed Bug 1123345 Opened 5 years ago Closed 5 years ago
_ICU _CFLAGS instead of in-tree paths for build with system icu
Or it seems I cannot build firefox with system icu other than version 52.1
I'm not sure about the differences between CXXFLAGS in moz.build and LOCAL_INCLUDES in Makefile.in, but this patch fixes my build.
Assignee: nobody → bzhao
Attachment #8551325 - Flags: review?(mh+mozilla)
Attachment #8551325 - Flags: review?(mh+mozilla) → review+
https://treeherder.mozilla.org/#/jobs?repo=try&revision=24b14bb6ffc2 Linux opt xpcshell failed with bug 1102923
could you provide a try run to make sure this breaks nothing ?
(In reply to Carsten Book [:Tomcat] from comment #3) > could you provide a try run to make sure this breaks nothing ? Sure, I'll update the bug with an url later. So the retriggered job also failed, but treeherder still shows it as running.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.