1123345 - Use MOZ_ICU_CFLAGS instead of in-tree paths for build with system icu

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Hector Zhao [:hectorz]]

Or it seems I cannot build firefox with system icu other than version 52.1

Comment 1

[Hector Zhao [:hectorz]]

Attachment: Patch

I'm not sure about the differences between CXXFLAGS in moz.build and LOCAL_INCLUDES in Makefile.in, but this patch fixes my build.

Comment 2

[Hector Zhao [:hectorz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=24b14bb6ffc2
Linux opt xpcshell failed with bug 1102923

Comment 3

[Carsten Book [:Tomcat]]

could you provide a try run to make sure this breaks nothing ?

Comment 4

[Hector Zhao [:hectorz]]

(In reply to Carsten Book [:Tomcat] from comment #3)
> could you provide a try run to make sure this breaks nothing ?

Sure, I'll update the bug with an url later.

So the retriggered job also failed, but treeherder still shows it as running.

Comment 5

[Hector Zhao [:hectorz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=51089b6e1ce9

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4fd9e642dc5d

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4fd9e642dc5d