Closed Bug 1123345 Opened 5 years ago Closed 5 years ago

Use MOZ_ICU_CFLAGS instead of in-tree paths for build with system icu

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla38

People

(Reporter: hectorz, Assigned: hectorz)

Details

Attachments

(1 file)

Or it seems I cannot build firefox with system icu other than version 52.1
Attached patch PatchSplinter Review
I'm not sure about the differences between CXXFLAGS in moz.build and LOCAL_INCLUDES in Makefile.in, but this patch fixes my build.
Assignee: nobody → bzhao
Attachment #8551325 - Flags: review?(mh+mozilla)
Attachment #8551325 - Flags: review?(mh+mozilla) → review+
could you provide a try run to make sure this breaks nothing ?
Flags: needinfo?(bzhao)
Keywords: checkin-needed
(In reply to Carsten Book [:Tomcat] from comment #3)
> could you provide a try run to make sure this breaks nothing ?

Sure, I'll update the bug with an url later.

So the retriggered job also failed, but treeherder still shows it as running.
Flags: needinfo?(bzhao)
https://hg.mozilla.org/mozilla-central/rev/4fd9e642dc5d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.