1123383 - SIMD (interpreter): remove Clamp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[:ProgramFOX]

Clamp has been removed from the SIMD polyfill:
https://github.com/johnmccutchan/ecmascript_simd/commit/6ff76ae9995501646d3b7d2df2fab4d7c3a0ef9f

Comment 1

[:ProgramFOX]

Attachment: Patch - Removed Clamp

Proposed patch that removes Clamp.

Comment 2

[:ProgramFOX]

Whoops, nevermind; I just noticed that Clamp got re-added [0]. Marking this as invalid.

[0]: https://github.com/johnmccutchan/ecmascript_simd/commit/6751101cd09bb3e60e548ab32f05f5e6090fc4b1

Comment 3

[:ProgramFOX]

Reopening this bug because Clamp got removed again:
https://github.com/johnmccutchan/ecmascript_simd/commit/901b6c7d5a54136e447cec36a8821176db5c423c

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8551380 [details] [diff] [review]
Patch - Removed Clamp

Review of attachment 8551380 [details] [diff] [review]:
-----------------------------------------------------------------

Hey ProgramFOX,
Just realized this was on my todo-list, but actually you already have a patch, so let's move it forward! r=me on the rebased patch (there shouldn't be a lot to change). Can you please rebase it, send it to the try server (on a separate try run), so that we can land it? Thanks!

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

See comment 4

Comment 6

[:ProgramFOX]

Sure, I'll rebase it as soon as bug 1124291 is landed (so I only have to rebase it once).

Comment 7

[:ProgramFOX]

Attachment: SIMD (interpreter): remove Clamp

Rebased patch.

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b53c2153817c

Comment 8

[:ProgramFOX]

Try returned all green, adding checkin-needed.

Comment 9

[Carsten Book [:Tomcat]]

sorry this failed to apply:

patching file js/src/builtin/SIMD.cpp
Hunk #1 FAILED at 1103
1 out of 1 hunks FAILED -- saving rejects to file js/src/builtin/SIMD.cpp.rej
patching file js/src/builtin/SIMD.h
Hunk #1 FAILED at 55
Hunk #2 FAILED at 108
2 out of 2 hunks FAILED -- saving rejects to file js/src/builtin/SIMD.h.rej
patching file js/src/tests/ecma_7/SIMD/clamp.js
Hunk #1 FAILED at 0
1 out of 1 hunks FAILED -- saving rejects to file js/src/tests/ecma_7/SIMD/clamp.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory


can you take a look, thanks!

Comment 10

[:ProgramFOX]

Ah, yup, it looks like I have to rebase my patch. I'm working on it.

Comment 11

[:ProgramFOX]

Attachment: SIMD (interpreter): remove Clamp

Rebased patch.

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee7f479748fb

Comment 12

[:ProgramFOX]

After retriggering J3 on Android (an exception occurred), all tests passed, adding checkin-needed.

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3054f69fb5a1

Comment 14

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b390f54186e6

Comment 15

[Carsten Book [:Tomcat]]

sorry had to back this out seems this caused https://treeherder.mozilla.org/logviewer.html#?job_id=11613830&repo=mozilla-inbound

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c79f19db872

Comment 17

[:ProgramFOX]

Hmm... I have no idea... it didn't happen on try either.

Pulsebot posted here that my patch got pushed again; does this mean that the errors were caused by another patch, or do I still have to take a closer look at it?

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Your patch wasn't at fault and I relanded it.

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4c79f19db872

Comment 20

[Florian Scholz (Open Web Docs)]

Removed from MDN docs.