1123394 - Shell interrupt handler can go re-entrant

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: dont-reenter-interrupt-callback

While debugging a test failure caused by the patch in bug 1120591, I found that the shell interrupt callback could be re-entered if another part of the system requested an interrupt while the callback function was executing.  

This can happen for example if a GC allocation threshold is passed in the callback.

The fix is to reset the gServiceInterrupt flag at the start of ShellInterruptCallback(), before we invoke the callback.

Comment 1

[Shu-yu Guo [:shu]]

Comment on attachment 8551387 [details] [diff] [review]
dont-reenter-interrupt-callback

Review of attachment 8551387 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch! Thanks for the patch.

Comment 2

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d6a46c2a96a

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9d6a46c2a96a

Comment 4

[Jon Coppeard (:jonco)]

Comment on attachment 8551387 [details] [diff] [review]
dont-reenter-interrupt-callback

Approval Request Comment
[Feature/regressing bug #]: Bug 1019612
[User impact if declined]: None, shell only.
[Describe test coverage new/current, TreeHerder]: On m-c for two weeks.
[Risks and why]: Low.
[String/UUID change made/needed]: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6b38a91ae086
https://hg.mozilla.org/releases/mozilla-beta/rev/6d9a99b090f5