rbmozuiautocomplete fails to work properly when searching by first name

NEW
Unassigned

Status

MozReview
General
P3
normal
3 years ago
2 years ago

People

(Reporter: mconley, Unassigned)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

STR:

1) In a new review request, click on the pencil icon next to "Reviewers" to set a reviewer
2) Type in some fragment of a user name *that does not match the IRC nick of the user*. Example, "Greg"
3) When the autocomplete popup opens, choose any option that does not match or is not prefixed by what you've already typed in.

ER:

What you select or press enter on should replace everything you've typed after and ","'s.

AR:

The autocomplete selection seems to be completely ignored.

Comment 1

3 years ago
Created attachment 8554320 [details]
MozReview Request: bz://1123458/gps

/r/2981 - rbmozui: test for reviewer autocomplete (bug 1123458)

Pull down this commit:

hg pull review -r adeef1a922865382be0514dae7fb0354b26ce7b7
Attachment #8554320 - Flags: review?(mconley)
https://reviewboard.mozilla.org/r/2981/#review2291

Always look on the bright side of life.

I analyzed your Python changes and found 5 errors.

The following files were examined:

  pylib/rbmozui/tests/test-autocomplete.py

::: pylib/rbmozui/tests/test-autocomplete.py
(Diff revision 1)
> +import os

F401: 'os' imported but unused

::: pylib/rbmozui/tests/test-autocomplete.py
(Diff revision 1)
> +        lr = self.mr.get_local_repository(
> +                'repo1',

E126: continuation line over-indented for hanging indent
Continuation lines indentation.

Continuation lines should align wrapped elements either vertically
using Python's implicit line joining inside parentheses, brackets
and braces, or using a hanging indent.

When using a hanging indent these considerations should be applied:
- there should be no arguments on the first line, and
- further indentation should be used to clearly distinguish itself as a
continuation line.

::: pylib/rbmozui/tests/test-autocomplete.py
(Diff revision 1)
> +        autocomplete = children.find_elements_by_class_name('ui-autocomplete-input')

E501: line too long (84 > 79 characters)
Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to have
several windows side-by-side.  The default wrapping on such devices looks
ugly.  Therefore, please limit all lines to a maximum of 79 characters.
For flowing long blocks of text (docstrings or comments), limiting the
length to 72 characters is recommended.

Reports error E501.

::: pylib/rbmozui/tests/test-autocomplete.py
(Diff revision 1)
> +        results = self.browser.find_elements_by_class_name('ui-autocomplete-results')

E501: line too long (85 > 79 characters)
Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to have
several windows side-by-side.  The default wrapping on such devices looks
ugly.  Therefore, please limit all lines to a maximum of 79 characters.
For flowing long blocks of text (docstrings or comments), limiting the
length to 72 characters is recommended.

Reports error E501.

::: pylib/rbmozui/tests/test-autocomplete.py
(Diff revision 1)
> +        import pdb; pdb.set_trace()

E702: multiple statements on one line (semicolon)
Compound statements (on the same line) are generally discouraged.

While sometimes it's okay to put an if/for/while with a small body
on the same line, never do this for multi-clause statements.
Also avoid folding such long lines!
Comment on attachment 8554320 [details]
MozReview Request: bz://1123458/gps

https://reviewboard.mozilla.org/r/2979/#review2293

::: pylib/rbmozui/tests/test-autocomplete.py
(Diff revision 1)
> +        import pdb; pdb.set_trace()

Leftover breakpoint

::: pylib/rbmozui/tests/test-autocomplete.py
(Diff revision 1)
> +        # If you comment this out and press ENTER from the browser, you
> +        # get an error. It works from Selenium. Strange.
> +        autocomplete.send_keys(Keys.ENTER)

Huh. That's kind of the crux of the test. What about pressing TAB instead before ENTER - any difference?
Attachment #8554320 - Flags: review?(mconley)

Updated

3 years ago
Priority: -- → P2

Comment 4

3 years ago
We have too many P1s, so I'm spreading out the priorities.  P3 -> P4, P2 -> P3, and some portion of P1s will become P2.
Priority: P2 → P3

Comment 5

3 years ago
Comment on attachment 8554320 [details]
MozReview Request: bz://1123458/gps
Attachment #8554320 - Attachment is obsolete: true

Comment 6

3 years ago
Created attachment 8619177 [details]
MozReview Request: rbmozui: test for reviewer autocomplete (bug 1123458)
(Assignee)

Updated

2 years ago
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.