Closed
Bug 1123461
Opened 10 years ago
Closed 10 years ago
Clean up js/ipc interfaces
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: billm, Assigned: billm)
Details
Attachments
(2 files)
36.42 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
9.41 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
The way this is done is pretty crummy. I made a new header file that exposes the entire external interface for js/ipc. The rest of Gecko can now just include this header file and everything else is kept private.
Attachment #8551479 -
Flags: review?(dvander)
Assignee | ||
Comment 1•10 years ago
|
||
This patch renames CpowIdHolder to CrossProcessCpowHolder. This better expresses its purpose (and fits well with SameProcessCpowHolder, which we also have).
Attachment #8551480 -
Flags: review?(dvander)
Updated•10 years ago
|
Attachment #8551479 -
Flags: review?(dvander) → review+
Updated•10 years ago
|
Attachment #8551480 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Both of these and the patch from bug 1123090 backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/1e53e8c79d9f for Windows build bustage:
https://treeherder.mozilla.org/logviewer.html#?job_id=5799592&repo=mozilla-inbound
Flags: needinfo?(wmccloskey)
Assignee | ||
Comment 4•10 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/901b357d7334
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/392964f0fc66
Flags: needinfo?(wmccloskey)
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/901b357d7334
https://hg.mozilla.org/mozilla-central/rev/392964f0fc66
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•