These three menu items are not functional, could be removed now. 1. Sort by Name 2. Sort by Category 3. Sort by Time Added
Hi Scott, Is it ok that the remaining items will align to the left? Otherwise, we may make them center-aligned.
Hi Luke, If items are less than 5, then they should always align center. And if items are more then 5, then they should align to left visually. So for this case, there are only a few item appears on option menu, then we should make them center-aligned. Hope this answer your question. thank, Scott
Hi Scott, It's clear. Thanks.
Created attachment 8551706 [details] [review] Pull request to master There is a bug of the scrollable element which causes the remaining items can't be center-aligned after this patch is landed. Since Rex has already been working on this, I only focus on removing the unused items and the "cancel" button in this bug. Hi Rex, Could you please take a look? Thank.
Comment on attachment 8551706 [details] [review] Pull request to master Looks good to me. Thank you!
Rex, Thanks for reviewing. gaia-try is passed: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=201b1c8a917e landed on master: https://github.com/mozilla-b2g/gaia/commit/a6b08f67dc6d4f5d4dee1252fa45dfef01ecc0b1