Closed
Bug 1123542
Opened 9 years ago
Closed 9 years ago
[Stingray] Remove unused context menu item in app deck
Categories
(Firefox OS Graveyard :: Gaia::TV, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dwi2, Assigned: lchang)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file)
These three menu items are not functional, could be removed now. 1. Sort by Name 2. Sort by Category 3. Sort by Time Added
Reporter | ||
Updated•9 years ago
|
Blocks: CardUI-Followup
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → lchang
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Hi Scott, Is it ok that the remaining items will align to the left? Otherwise, we may make them center-aligned.
Flags: needinfo?(scwu)
Hi Luke, If items are less than 5, then they should always align center. And if items are more then 5, then they should align to left visually. So for this case, there are only a few item appears on option menu, then we should make them center-aligned. Hope this answer your question. thank, Scott
Flags: needinfo?(scwu)
Assignee | ||
Comment 3•9 years ago
|
||
Hi Scott, It's clear. Thanks.
Assignee | ||
Comment 4•9 years ago
|
||
There is a bug of the scrollable element which causes the remaining items can't be center-aligned after this patch is landed. Since Rex has already been working on this, I only focus on removing the unused items and the "cancel" button in this bug. Hi Rex, Could you please take a look? Thank.
Attachment #8551706 -
Flags: review?(rexboy)
Comment 5•9 years ago
|
||
Comment on attachment 8551706 [details] [review] Pull request to master Looks good to me. Thank you!
Attachment #8551706 -
Flags: review?(rexboy) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Rex, Thanks for reviewing. gaia-try is passed: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=201b1c8a917e landed on master: https://github.com/mozilla-b2g/gaia/commit/a6b08f67dc6d4f5d4dee1252fa45dfef01ecc0b1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•