If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Stingray] Remove unused context menu item in app deck

RESOLVED FIXED

Status

Firefox OS
Gaia::TV
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dwi2, Assigned: lchang)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
These three menu items are not functional, could be removed now.
1. Sort by Name
2. Sort by Category
3. Sort by Time Added
(Reporter)

Updated

3 years ago
Blocks: 1105935
(Assignee)

Updated

3 years ago
Assignee: nobody → lchang
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Hi Scott,

Is it ok that the remaining items will align to the left? Otherwise, we may make them center-aligned.
Flags: needinfo?(scwu)

Comment 2

3 years ago
Hi Luke,

If items are less than 5, then they should always align center. And if items are more then 5, then they should align to left visually. So for this case, there are only a few item appears on option menu, then we should make them center-aligned. Hope this answer your question. 

thank,
Scott
Flags: needinfo?(scwu)
(Assignee)

Comment 3

3 years ago
Hi Scott, It's clear. Thanks.
(Assignee)

Comment 4

3 years ago
Created attachment 8551706 [details] [review]
Pull request to master

There is a bug of the scrollable element which causes the remaining items can't be center-aligned after this patch is landed. Since Rex has already been working on this, I only focus on removing the unused items and the "cancel" button in this bug.


Hi Rex,

Could you please take a look? Thank.
Attachment #8551706 - Flags: review?(rexboy)
Comment on attachment 8551706 [details] [review]
Pull request to master

Looks good to me.
Thank you!
Attachment #8551706 - Flags: review?(rexboy) → review+
(Assignee)

Comment 6

3 years ago
Rex, Thanks for reviewing.

gaia-try is passed: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=201b1c8a917e
landed on master: https://github.com/mozilla-b2g/gaia/commit/a6b08f67dc6d4f5d4dee1252fa45dfef01ecc0b1
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.