Closed Bug 1123728 Opened 8 years ago Closed 8 years ago

Add open CORS header when in DEBUG mode

Categories

(MozReview Graveyard :: General, defect)

Product:
MozReview Graveyard
Component:
General
Version:
Production
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mcote, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

MozReview Request: Bug 1123728 - rbbz: When in DEBUG mode, add an open CORS header.
39 bytes, text/x-review-board-request
smacleod
: review+
Details 
For testing Bugzilla interaction with Review Board, we need a CORS header in the latter, since Bugzilla and Review Board are different hosts.
Attached file MozReview Request: bz://1123728/mcote (obsolete) — 

        Attachment #8551845 -
        Flags: review?(smacleod)

    
    

    
  
/r/2715 - Bug 1123728 - rbbz: When in DEBUG mode, add an open CORS header.

Pull down this commit:

hg pull review -r 6a6386b2e3ab8e41ed16bf31a702a84d53496cc7

    
    

    
  
https://reviewboard.mozilla.org/r/2713/#review1809

My super quick look sais this is fine. I haven't thought deeply about the security implications since we're only doing this with DEBUG True.

::: pylib/rbbz/rbbz/middleware.py
(Diff revision 1)
> +        if settings.DEBUG:

Are we running with settings.DEBUG = True on reviewboard-dev?

Are we cool with having this header on there?

        Attachment #8551845 -
        Flags: review?(smacleod) → review+

    
    

    
  
I don't think we are, but this should be fine anyway even if it is.

http://hg.mozilla.org/hgcustom/version-control-tools/rev/c672af88ed12
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED

    
    

    
  

        Attachment #8551845 -
        Attachment is obsolete: true

        Attachment #8619179 -
        Flags: review+
Product: Developer Services → MozReview

          You need to log in
          before you can comment on or make changes to this bug.