1123728 - Add open CORS header when in DEBUG mode

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Mark Côté [:mcote]]

For testing Bugzilla interaction with Review Board, we need a CORS header in the latter, since Bugzilla and Review Board are different hosts.

Comment 1

[Mark Côté [:mcote]]

Attachment: MozReview Request: bz://1123728/mcote

Comment 2

[Mark Côté [:mcote]]

/r/2715 - Bug 1123728 - rbbz: When in DEBUG mode, add an open CORS header.

Pull down this commit:

hg pull review -r 6a6386b2e3ab8e41ed16bf31a702a84d53496cc7

Comment 3

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/2713/#review1809

My super quick look sais this is fine. I haven't thought deeply about the security implications since we're only doing this with DEBUG True.

::: pylib/rbbz/rbbz/middleware.py
(Diff revision 1)
> +        if settings.DEBUG:

Are we running with settings.DEBUG = True on reviewboard-dev?

Are we cool with having this header on there?

Comment 4

[Mark Côté [:mcote]]

I don't think we are, but this should be fine anyway even if it is.

http://hg.mozilla.org/hgcustom/version-control-tools/rev/c672af88ed12

Comment 6

[Mark Côté [:mcote]]

Attachment: MozReview Request: Bug 1123728 - rbbz: When in DEBUG mode, add an open CORS header.