1123754 - Move ProfilerMarker class declaration / definition to easily-findable places

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Markus Stange [:mstange]]

The definitions of the ProfilerMarker methods are located in platform.cpp.
Guess which file contains the class declaration: platform.h, ProfilerMarkers.h or PseudoStack.h?

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Rename ProfilerMarkers.{h,cpp} as ProfilerMarkerPayload.{h,cpp}

Because ProfilerMarkerPayload is the main type defined in these files, and
because the next patch is going to introduce ProfilerMarker.{h,cpp}, which
would be confusingly similar to the old names.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Move ProfilerMarker into ProfilerMarker.h

ProfilerMarker is simple enough that it's best to fully define it in
ProfilerMarker.h, without introducing a ProfilerMarker.cpp.

This requires moving STORE_SEQUENCER() into its own header, StoreSequencer.h.

As a result, the following types are no longer visible outside the profiler:
ProfilerMarker, ProfilerLinkedList, ProfilerMarkerLinkedList,
ProfilerSignalSafeLinkedList. (PseudoStack.h now contains the PseudoStack class
and nothing else.)

The patch also makes the following non-obvious changes.

- It changes ProfilerMarker::{mMarkerName,mPayload} to unique pointers, which
  removes the need for an explicit ~ProfilerMarker().

- It removes ProfilerMarker::GetMarkerName(), because that method is only used
  within ProfilerMarker itself.

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/32f4e2a4874cbab57513d349b67b47f18a9bd5bd
Bug 1123754 (part 1) - Rename ProfilerMarkers.{h,cpp} as ProfilerMarkerPayload.{h,cpp}. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa3cd4933f88b86f893d58b684b2454ef273f140
Bug 1123754 (part 2) - Move ProfilerMarker into ProfilerMarker.h. r=mstange.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/32f4e2a4874c
https://hg.mozilla.org/mozilla-central/rev/aa3cd4933f88