1123776 - Keyboard shortcut tables on https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly should use scoped headers

Status: REOPENED

(support.mozilla.org :: Knowledge Base Software, task, P3)

Description

[:Gijs (he/him)]

So the labels of the rows should be <th scope="row"> instead of <td> as they are now.

This probably applies to other tables on SuMO's kb, but I don't know what infrastructure we have to look for those in a structural manner.

Comment 1

[:Gijs (he/him)]

David, the sec508 report also mentioned the column headers; I was under the impression that th without a scope auto-defaults to column, which seems correct to me here, so I don't think that needs any additional/different markup, is that right?

Comment 2

[Michael Cooper [:mythmon]]

This is a deficiency in our wiki syntax parser/html generator. The cells in question are marked as "headers" in the wiki markup, but the html generator turns those in to bolded tds instead of ths like it should.

Estimation: The wiki syntax generator is obnoxious. This might even be out of our direct control. 2pts to dig around in the wiki syntax's html generator. If this ends up being part of the library, it will be more work to get fixed.

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to :Gijs Kruitbosch from comment #1)
> David, the sec508 report also mentioned the column headers; I was under the
> impression that th without a scope auto-defaults to column, which seems
> correct to me here, so I don't think that needs any additional/different
> markup, is that right?

Yes I think that is correct.

Comment 4

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381

Comment 5

[Abby Parise]

Closing outdated request.

Comment 6

[:Gijs (he/him)]

Why was this closed? This issue still exists on this page and has not been fixed.

Comment 7

[Leo McArdle [:leo]]

Abby's been cleaning up outdated KB content requests, so moving this to the KB software component.