1123842 - don't allow ipc accessibility to ride the 37 train

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Trevor Saunders (:tbsaunde)]

This code is only useful with e10s on, and that's not the default for
this train, so enabling this code incurs risk for no purpose.

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: don't allow ipc accessibility to ride the 37 train

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8551947 [details] [diff] [review]
don't allow ipc accessibility to ride the 37 train

Approval Request Comment
[Feature/regressing bug #]: none / e10s a11y meta bug
[User impact if declined]: crashes
[Describe test coverage new/current, TreeHerder]:n/a
[Risks and why]:  low, this is just disabling new code.
[String/UUID change made/needed]:

Comment 3

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8551947 [details] [diff] [review]
don't allow ipc accessibility to ride the 37 train

Thanks for flagging that this should be disabled in 37. Aurora+

Comment 4

[Lawrence Mandel [:lmandel] (use needinfo)]

Ack. Jumped the gun. This has Aurora approval to land once dbolter providers an r+.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8551947 [details] [diff] [review]
don't allow ipc accessibility to ride the 37 train

Review of attachment 8551947 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, note we could use accessibility.ipc_architecture.enabled if we want people to be able to experiment.

Comment 6

[alexander :surkov (:asurkov)]

(In reply to David Bolter [:davidb] from comment #5)
> Comment on attachment 8551947 [details] [diff] [review]

> r=me, note we could use accessibility.ipc_architecture.enabled if we want
> people to be able to experiment.

turned to false by default as I suggested ;)

Comment 7

[Trevor Saunders (:tbsaunde)]

(In reply to David Bolter [:davidb] from comment #5)
> Comment on attachment 8551947 [details] [diff] [review]
> don't allow ipc accessibility to ride the 37 train
> 
> Review of attachment 8551947 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me, note we could use accessibility.ipc_architecture.enabled if we want
> people to be able to experiment.

I don't see why we want anybody to experiment with stuff that's old and known to be broken.  So we might as well let the compiler remove code that is under checks of this.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cedca912633b