1123892 - [RTL] [Settings] Brightness Slider is missing under Display

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Delphine Lebédel [:delphine - Use needinfo]]

Attachment: display.png

Description:
Under Settings > Display, notice how the Brightness slider does not appear anymore (see screenshot)

Expected: Brightness slider should appear and brightness progression is mirrored, as shown by the direction of the icons on each side.

Note: this does not happen with non-RTL locales

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Issue found on today's v2.2 on Flame device
Gaia-Rev        f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5d7497ce4cc7
Build-ID        20150120002507
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  39
FW-Date         Thu Oct 16 18:19:14 CST 2014
Bootloader      L1TC00011880

Current Master (v3.0) affected as well
Gaia-Rev        a5c5ac093814a80b0627514c3bd5f9e96c096a4b
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/c1c6840d9255
Build-ID        20150120010227
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  40
FW-Date         Tue Oct 21 15:59:42 CST 2014
Bootloader      L1TC10011880


Adding the regression keyword as this did not occur when Bug 1115174 was filed.
Nominating as 2.2 blocker, and ni Bhavana for blocking approval

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

I think this is Gecko bug instead of Gaia's.

I did use QA's flash tool to flash different versions of Gecko (please check build id below) with latest Gaia.

--
2015-01-09-16-02-57 broken
2015-01-07-16-02-20 broken
2015-01-06-16-02-03 work
2015-01-05-16-02-15 work
--

And you can see the regression happened between 2015-01-06 & 2015-01-07.

Because I always use latest Gaia to verify this bug, so we can notice that this can be Gecko's bug. After checking some related bugs, I found bug 1121748 may be the fix for this bug.

Comment 3

[Ahmed Nefzaoui [:Nefzaoui]]

(In reply to EJ Chen [:eragonj][:小龍哥][ni? if you need me] from comment #2)
> I think this is Gecko bug instead of Gaia's.
> 
> I did use QA's flash tool to flash different versions of Gecko (please check
> build id below) with latest Gaia.
> 
> --
> 2015-01-09-16-02-57 broken
> 2015-01-07-16-02-20 broken
> 2015-01-06-16-02-03 work
> 2015-01-05-16-02-15 work
> --
> 
> And you can see the regression happened between 2015-01-06 & 2015-01-07.
> 
> Because I always use latest Gaia to verify this bug, so we can notice that
> this can be Gecko's bug. After checking some related bugs, I found bug
> 1121748 may be the fix for this bug.

Yes it is

Comment 4

[Dylan Oliver [:doliver]]

RTL update: marking required bugs as feature-b2g:2.2+ (and removing blocking flags)

Comment 5

[Clément Lefèvre]

Not only the slider, the "adjust automatically" setting for the brightness just is not here: empty line.

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Delphine,

can you try again with latest v2.2 build ? I just noticed that its dependent Gecko bug got fixed in bug 1121748 already.

I just gave it a test and all UI looks well and there is no empty line for "adjust automatically", either. (check comment 5)

== my build information ==
Gaia-Rev        46b590648007d51a0406b21b1d6f98eba8e3898e
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/b03afde7e699
Build-ID        20150128162504
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150120.192939
FW-Date         Tue Jan 20 19:29:50 EST 2015
Bootloader      L1TC10011800
== end ==

If this bug got verified, I think we can mark this bug as invalid. Thanks !!

Comment 7

[Clément Lefèvre]

I check and yes, the empty line is not empty anymore. It still have the missing slider though.

Comment 8

[Delphine Lebédel [:delphine - Use needinfo]]

Attachment: 2015-01-29-15-52-45.png

Comment 9

[Delphine Lebédel [:delphine - Use needinfo]]

Hiya! Thanks Clément and :eragonj for looking into this. 
So as of today I see everything looks ok: both slider and text are there! See attached screenshot

Device Information:
OS version: prerelease-2.2.0.0
Gecko revision="f231a089e5484c25a3b5137337b3f9d169f37d2a"
Gaia revision= "6e494f1d2676d231abba7dcc2e2822d1170d2d02"
Hardware revision:qcom
Platform version: 37.0a2
20150129003432
Update channel: nightly-b2g37

Closing as WORKSFORME

Comment 10

[Clément Lefèvre]

Checking again, I still have a missing slider on latest master build, and sometimes empty line.

Flame on 3.0

Build ID               20150129160230
Build Type             user
Gaia Revision          8238eeacc7030b2cdbf7ab4eba2f36779b702599
Gaia Date              2015-01-29 17:47:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/29b05d283b00
Gecko Version          38.0a1
Device ID              flame
Firmware(Release)      4.4.2
Firmware(Incremental)  39
Firmware Date          Thu Oct 16 18:19:14 CST 2014
Bootloader             L1TC00011880

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Clement, you may use the wrong version to verify this. Right now, related patch is only included in v2.2 and the layout team is working hard to get a proper fix in the trunk (Please check bug 1121748 for more information).

So, this bug should be fixed if you flash with v2.2. Thanks.

Comment 12

[Clément Lefèvre]

(In reply to EJ Chen [:eragonj][:小龍哥][ni? if you need me] from comment #11)
> Hi Clement, you may use the wrong version to verify this. Right now, related
> patch is only included in v2.2 and the layout team is working hard to get a
> proper fix in the trunk (Please check bug 1121748 for more information).
> 
> So, this bug should be fixed if you flash with v2.2. Thanks.

Mmmh, ok. I thought every fix was going first to Master/nightlies before landing in lower versions, as for a test.
I will not flash to 2.2 right now, but if you say it's fixed inside, ok. I will have to wait for the fix to land in master.

Comment 13

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15679/