Closed
Bug 1123905
Opened 11 years ago
Closed 10 years ago
Stop depending on test-utils
Categories
(Socorro :: Webapp, task)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: peterbe, Assigned: peterbe)
References
Details
Attachments
(1 file)
We don't need test-utils. It's not an actively maintained project.
The main benefit of test-utils was that it allowed us to add a `settings_tests.py` file which makes sure no local settings influence settings needed for tests.
There are better ways to fold in the same functionality is something somewhat more explicit and obvious. For example here how fjord does it: https://github.com/mozilla/fjord/blob/master/fjord/settings/__init__.py#L19
See our [0] https://github.com/mozilla/socorro/blob/master/webapp-django/settings_test.py
| Assignee | ||
Updated•10 years ago
|
Assignee: nobody → peterbe
| Assignee | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/socorro
https://github.com/mozilla/socorro/commit/78db1a9e4487acda0bbf73f811fdca9a46c20e9e
fixes bug 1123905 - Stop depending on test-utils
https://github.com/mozilla/socorro/commit/0e0c2e4c15bcda3953f3df422373847ed774ea12
Merge pull request #3040 from peterbe/bug-1123905-stop-depending-on-test-utils
fixes bug 1123905 - Stop depending on test-utils
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•