1123936 - Intermittent browser_animation_actors_02.js | The animation is currently running - Got pending, expected running

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

15:20:22 INFO - 5474 INFO TEST-START | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js
15:20:22 INFO - -*-*- UserCustomizations (parent): document created: http://test1.example.org/browser/toolkit/devtools/server/tests/browser/animation.html
15:20:22 INFO - -*-*- UserCustomizations (parent): _injectInWindow
15:20:22 INFO - -*-*- UserCustomizations (parent): principal status: 0
15:20:22 INFO - 5475 INFO checking window state
15:20:22 INFO - 5476 INFO Entering test
15:20:22 INFO - 5477 INFO Adding a new tab with URL: 'http://test1.example.org/browser/toolkit/devtools/server/tests/browser/animation.html'
15:20:22 INFO - 5478 INFO Waiting for event: 'load' on [object XULElement].
15:20:22 INFO - 5479 INFO Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://test1.example.org/browser/toolkit/devtools/server/tests/browser/animation.html" line: 0}]
15:20:22 INFO - 5480 INFO Got event: 'load' on [object XULElement].
15:20:22 INFO - 5481 INFO URL 'http://test1.example.org/browser/toolkit/devtools/server/tests/browser/animation.html' loading complete
15:20:22 INFO - 5482 INFO TEST-PASS | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | 0 players were returned for the unanimated node
15:20:22 INFO - 5483 INFO TEST-PASS | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | One animation player was returned
15:20:22 INFO - 5484 INFO TEST-PASS | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | Two animation players were returned
15:20:22 INFO - 5485 INFO TEST-PASS | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | One animation player was returned for the transitioned node
15:20:22 INFO - 5486 INFO TEST-PASS | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | The player has an initialState
15:20:22 INFO - 5487 INFO TEST-PASS | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | The player has the getCurrentState method
15:20:22 INFO - 5488 INFO TEST-UNEXPECTED-FAIL | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | The animation is currently running - Got pending, expected running
15:20:22 INFO - Stack trace:
15:20:22 INFO - chrome://mochikit/content/browser-test.js:test_is:851
15:20:22 INFO - chrome://mochitests/content/browser/toolkit/devtools/server/tests/browser/browser_animation_actors_02.js:playersCanBePausedAndResumed:53
15:20:22 INFO - self-hosted:InterpretGeneratorResume:659
15:20:22 INFO - self-hosted:next:585
15:20:22 INFO - Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:23
15:20:22 INFO - this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:7
15:20:22 INFO - this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:37
15:20:22 INFO - 5489 INFO TEST-PASS | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | The animation is now paused
15:20:22 INFO - 5490 INFO TEST-PASS | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | The animation is now running again
15:20:22 INFO - 5491 INFO Leaving test
15:20:23 INFO - 5492 INFO MEMORY STAT vsize after test: 795652096
15:20:23 INFO - 5493 INFO MEMORY STAT vsizeMaxContiguous after test: 439091200
15:20:23 INFO - 5494 INFO MEMORY STAT residentFast after test: 550662144
15:20:23 INFO - 5495 INFO MEMORY STAT heapAllocated after test: 241860134
15:20:23 INFO - 5496 INFO TEST-OK | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | took 293ms

Comment 1

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-aurora&job_id=524354
repository: mozilla-aurora
start_time: 2015-01-19T14:59:40
who: rvandermeulen[at]mozilla[dot]com
machine: t-xp32-ix-061
buildname: Windows XP 32-bit mozilla-aurora pgo test mochitest-devtools-chrome
revision: e86a967b9875

5488 INFO TEST-UNEXPECTED-FAIL | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | The animation is currently running - Got pending, expected running
Return code: 1

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Sending over to pbrosset

Comment 3

[Patrick Brosset <:pbro>]

That's an easy fix. Recently web animations have had a new thing whereby they go through a pending state before starting to run, and there's a ready promise that consumers can wait for in that case.
This promise is already available on the AnimationPlayerActor, so it's just a matter of adding a step to the intermittent failing test to wait for this promise to resolve.

Comment 4

[Patrick Brosset <:pbro>]

Attachment: bug1123936-intermittent-browser_animation_actors_02.js.patch

Some background for Brian: the test fails since bug 927349 landed. That bug made animations pass by a pending state shortly before starting, and also exposed a 'ready' promise on AnimationPlayer objects.
The failing test assumed the animation was running no matter what.
Since bug 1113091, I've exposed the ready promise on AnimationPlayerActor objects. So the test just has to wait until the front.ready promise resolves.

Pending try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a3931b9c52f

Comment 5

[Patrick Brosset <:pbro>]

That's right, this intermittent made it to 37. I'll request uplift once it gets reviewed and lands on central.
The try push is green so far.

Comment 6

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-aurora&job_id=535633
repository: mozilla-aurora
start_time: 2015-01-23T03:52:08
who: philringnalda[at]gmail[dot]com
machine: t-xp32-ix-018
buildname: Windows XP 32-bit mozilla-aurora pgo test mochitest-devtools-chrome
revision: 79fcabb42355

5488 INFO TEST-UNEXPECTED-FAIL | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | The animation is currently running - Got pending, expected running
Return code: 1

Comment 7

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-aurora&job_id=538436
repository: mozilla-aurora
start_time: 2015-01-25T12:12:03
who: philringnalda[at]gmail[dot]com
machine: t-xp32-ix-055
buildname: Windows XP 32-bit mozilla-aurora pgo test mochitest-devtools-chrome
revision: 3ba70e3d1e0d

5488 INFO TEST-UNEXPECTED-FAIL | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | The animation is currently running - Got pending, expected running
Return code: 1

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/b792e9c41c66

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b792e9c41c66

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/87a0f1b69040

Comment 11

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-aurora&job_id=545429
repository: mozilla-aurora
start_time: 2015-01-28T10:06:03
who: rvandermeulen[at]mozilla[dot]com
machine: t-xp32-ix-029
buildname: Windows XP 32-bit mozilla-aurora pgo test mochitest-devtools-chrome
revision: 2dca8b96f733

5488 INFO TEST-UNEXPECTED-FAIL | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | The animation is currently running - Got pending, expected running
Return code: 1

Comment 12

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-aurora&job_id=568527
repository: mozilla-aurora
start_time: 2015-02-05T09:16:10
who: rvandermeulen[at]mozilla[dot]com
machine: t-xp32-ix-011
buildname: Windows XP 32-bit mozilla-aurora pgo test mochitest-devtools-chrome
revision: afb266213a03

5488 INFO TEST-UNEXPECTED-FAIL | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | The animation is currently running - Got pending, expected running
Return code: 1

Comment 13

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-aurora&job_id=570614
repository: mozilla-aurora
start_time: 2015-02-05T15:04:34
who: rvandermeulen[at]mozilla[dot]com
machine: t-xp32-ix-093
buildname: Windows XP 32-bit mozilla-aurora pgo test mochitest-devtools-chrome
revision: a57cce6af02c

5486 INFO TEST-UNEXPECTED-FAIL | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | The animation is currently running - Got pending, expected running
Return code: 1

Comment 14

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-aurora&job_id=611144
repository: mozilla-aurora
start_time: 2015-02-19T21:10:50
who: philringnalda[at]gmail[dot]com
machine: t-xp32-ix-110
buildname: Windows XP 32-bit mozilla-aurora pgo test mochitest-devtools-chrome
revision: 9c590c364f26

5488 INFO TEST-UNEXPECTED-FAIL | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | The animation is currently running - Got pending, expected running
Return code: 1

Comment 15

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-aurora&job_id=611235
repository: mozilla-aurora
start_time: 2015-02-19T21:55:39
who: philringnalda[at]gmail[dot]com
machine: t-xp32-ix-131
buildname: Windows XP 32-bit mozilla-aurora pgo test mochitest-devtools-chrome
revision: d55d3ca3e685

5488 INFO TEST-UNEXPECTED-FAIL | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | The animation is currently running - Got pending, expected running
Return code: 1

Comment 16

[Patrick Brosset <:pbro>]

Sorry, this is a bit of a mess. The patch in this bug was the right idea, but the fix was incorrect:

yield player.ready
instead of
yield player.ready()

So this doesn't make anything fail, and since the bug was intermittent to start with, we didn't realize that the patch didn't solve the issue right away.

Also, I have actually fixed this issue for good on nightly since then (in bug 1122466 apparently).
So this intermittent remains in Aurora.

I don't know if it's a good idea to uplift bug 1122466 now. I'd rather just provide a new patch here just for Aurora (a patch that just adds the () parens after yield player.ready).

Ryan, is that something I can do?

Comment 17

[Ryan VanderMeulen [:RyanVM]]

If you're worried about uplifting bug 1122466, then a simple test-only fix sounds like a great idea :)

Comment 18

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: bz://1123936/pbrosset

/r/4097 - Bug 1123936 - Aurora-only fix for browser_animation_actors_02.js; r=me

Pull down this commit:

hg pull review -r a34c2a30cb9abe612254fabdd14e52e536b249bc

Comment 19

[Patrick Brosset <:pbro>]

Comment on attachment 8567139 [details]
MozReview Request: bz://1123936/pbrosset

https://reviewboard.mozilla.org/r/4095/#review3259

Ship It!

Comment 20

[Patrick Brosset <:pbro>]

So, I've made an Aurora-only patch (since that particular change already exists on nightly).
It's a test only change that will have absolutely no impacts except from fixing the intermittent on Aurora, so I've gone ahead and R+'d it myself. I hope that's ok. I think it is because that exact fix already exists on Nightly and has been R+'d there for some time.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/eff1d6a08c1a

Comment 22

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-beta&job_id=295873
repository: mozilla-beta
start_time: 2015-03-09T17:58:58
who: rvandermeulen[at]mozilla[dot]com
machine: t-xp32-ix-156
buildname: Windows XP 32-bit mozilla-beta pgo test mochitest-devtools-chrome
revision: 89b593b91e5e

5486 INFO TEST-UNEXPECTED-FAIL | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | The animation is currently running - Got pending, expected running
Return code: 1

Comment 23

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-beta&job_id=303754
repository: mozilla-beta
start_time: 2015-03-13T01:30:52
who: rvandermeulen[at]mozilla[dot]com
machine: t-xp32-ix-111
buildname: Windows XP 32-bit mozilla-beta pgo test mochitest-devtools-chrome
revision: 84cb53dff47c

5486 INFO TEST-UNEXPECTED-FAIL | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | The animation is currently running - Got pending, expected running
Return code: 1

Comment 24

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-beta&job_id=318064
repository: mozilla-beta
start_time: 2015-03-23T10:40:13
who: rvandermeulen[at]mozilla[dot]com
machine: t-xp32-ix-053
buildname: Windows XP 32-bit mozilla-beta pgo test mochitest-devtools-chrome
revision: 0725e4cfa3c3

5486 INFO TEST-UNEXPECTED-FAIL | toolkit/devtools/server/tests/browser/browser_animation_actors_02.js | The animation is currently running - Got pending, expected running
Return code: 1

Comment 26

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: Bug 1123936 - Aurora-only fix for browser_animation_actors_02.js; r=me