1124112 - [Stingray] Seamlessly launch search app from home

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[Evelyn Hung]

We need some tricks on launching search application to let it look like seamlessly transited from Home app.
1. delay the time of hiding searchBar on Home (in home.js after calling MozActivity) to after getting visibility change event. (make sure it's hidden in background)

2. remove search app launching animation and switch it to foreground after mozbrowserloadend event.

Comment 1

[Luke Chang [:lchang] (inactive)]

Attachment: Pull request to master

Hi John,

Could you help for reviewing it? Thanks.

Comment 2

[Luke Chang [:lchang] (inactive)]

Attachment: Dummy search app

This dummy search app could help for verifying this bug.

Comment 3

[kiwata.moz]

Hi Evelyn-san and all,

This is Iwata. I tried your patch on our system, and verified a improvement.
However still we can see start-up icon at the first time to launch search app,
and 2nd time or later, we can see a blank between Home and Search.
I'll send a video on this behavior.

Comment 4

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8552402 [details] [review]
Pull request to master

Hi Iwata-san,

I saw the problem and found a possible cause. I'll try fixing it tomorrow. Thanks for the help.

Comment 5

[Luke Chang [:lchang] (inactive)]

Hi Iwata-san,

I've just updated my patch. Could you please try it again? Thanks.

Comment 6

[kiwata.moz]

Hi Luke-san,

Thanks for your new patch.
The new one fixes the 1st issue, however 2nd one is still remaining...
If you want to see and debug this directly, please use the lab. environment.

Regards.

Comment 7

[Luke Chang [:lchang] (inactive)]

Hi Iwata-san,

I've updated again! Please help verifying it. Thanks.

Comment 8

[kiwata.moz]

Hi Luke-san,

Unfortunately it looks no difference with previous patch.
The gap still remains between Home and Search for the 2nd launch.
If Search app should modify something, please let me know.

Regards.

Comment 9

[Luke Chang [:lchang] (inactive)]

Hi Iwata-san,

I've uploaded the final version of this patch. Could you help me to verify it again? Thanks a lot.

Comment 10

[kiwata.moz]

Hi Luke-san,

This patch works fine! Thank you for your improvement.

Comment 11

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8552402 [details] [review]
Pull request to master

Hi John,

Per comment 10, this patch works now. Could you help to review it? Thanks.

Comment 12

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8552402 [details] [review]
Pull request to master

looks good to me.

Comment 13

[Luke Chang [:lchang] (inactive)]

John, Thanks a lot.

gaia-try: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=c39737acf0e0
landed on master: https://github.com/mozilla-b2g/gaia/commit/17365d407b4d74e1b3fcd85b3484516e6260f683