1124118 - Follow up nsIProgressEventSink.onProgress and nsITransport.onTransportStatus changes by bug 1116867

Status: RESOLVED FIXED

(MailNews Core :: Networking, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

nsIProgressEventSink.onProgress and nsITransport.onTransportStatus has been changed by bug 1116867.

We need to follow up the changes.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Make buildable

Not test yet.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Now pushed to try.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c1e0b8f16c5c

Comment 3

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=7985
repository: comm-central
start_time: 2015-01-21T03:04:02
who: archaeopteryx[at]coole-files[dot]de
machine: bld-linux64-spot-231
buildname: TB Linux comm-central nightly
revision: 5a9bae1b20e2

/builds/slave/tb-c-cen-lx-ntly-0000000000000/build/mailnews/local/src/nsPop3Protocol.h:272:20: error: 'virtual nsresult nsPop3Protocol::OnTransportStatus(nsITransport*, nsresult, uint64_t, uint64_t)' marked override, but does not override
make[5]: *** [nsPop3IncomingServer.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [mailnews/local/src/target] Error 2
make[4]: *** Waiting for unfinished jobs....
/builds/slave/tb-c-cen-lx-ntly-0000000000000/build/mailnews/base/util/nsMsgProtocol.cpp:751:1: error: prototype for 'nsresult nsMsgProtocol::OnTransportStatus(nsITransport*, nsresult, uint64_t, uint64_t)' does not match any in class 'nsMsgProtocol'
/builds/slave/tb-c-cen-lx-ntly-0000000000000/build/mailnews/base/util/nsMsgProtocol.h:62:20: error: candidate is: virtual nsresult nsMsgProtocol::OnTransportStatus(nsITransport*, nsresult, int64_t, int64_t)
make[5]: *** [nsMsgProtocol.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [mailnews/base/util/target] Error 2
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 4

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=7986
repository: comm-central
start_time: 2015-01-21T03:04:02
who: archaeopteryx[at]coole-files[dot]de
machine: bld-linux64-spot-238
buildname: TB Linux x86-64 comm-central nightly
revision: 5a9bae1b20e2

/builds/slave/tb-c-cen-l64-ntly-000000000000/build/mailnews/local/src/nsPop3Protocol.h:272:20: error: 'virtual nsresult nsPop3Protocol::OnTransportStatus(nsITransport*, nsresult, uint64_t, uint64_t)' marked override, but does not override
make[5]: *** [nsPop3IncomingServer.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 5

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=7989
repository: comm-central
start_time: 2015-01-21T03:02:26
who: archaeopteryx[at]coole-files[dot]de
machine: b-2008-ix-0065
buildname: TB WINNT 5.2 comm-central nightly
revision: 5a9bae1b20e2

c:\builds\moz2_slave\tb-c-cen-w32-ntly-000000000000\build\mailnews\local\src\nsPop3Protocol.h(272) : error C3668: 'nsPop3Protocol::OnTransportStatus' : method with override specifier 'override' did not override any base class methods
mozmake.exe[5]: *** [nsPop3IncomingServer.obj] Error 2
mozmake.exe[4]: *** [mailnews/local/src/target] Error 2
mozmake.exe[4]: *** Waiting for unfinished jobs....
mozmake.exe[3]: *** [compile] Error 2
mozmake.exe[2]: *** [default] Error 2
mozmake.exe[1]: *** [build] Error 2
mozmake.exe: *** [build] Error 2

Comment 6

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=7987
repository: comm-central
start_time: 2015-01-21T03:03:51
who: archaeopteryx[at]coole-files[dot]de
machine: bld-lion-r5-012
buildname: TB OS X 10.7 comm-central nightly
revision: 5a9bae1b20e2

/builds/slave/tb-c-cen-osx64-ntly-0000000000/build/mailnews/base/util/nsMsgProtocol.cpp:751:16: error: out-of-line definition of 'OnTransportStatus' does not match any declaration in 'nsMsgProtocol'
make[6]: *** [nsMsgProtocol.o] Error 1
make[6]: *** Waiting for unfinished jobs....
make[5]: *** [mailnews/base/util/target] Error 2
make[5]: *** Waiting for unfinished jobs....
/builds/slave/tb-c-cen-osx64-ntly-0000000000/build/mailnews/local/src/nsPop3Protocol.h:272:14: error: 'OnTransportStatus' marked 'override' but does not override any member functions
make[6]: *** [nsPop3IncomingServer.o] Error 1
make[6]: *** Waiting for unfinished jobs....
make[5]: *** [mailnews/local/src/target] Error 2
make[4]: *** [compile] Error 2
make[3]: *** [default] Error 2
make[2]: *** [build] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Attachment: bug1124118.patch

Tests on the try seem good.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 8552429 [details] [diff] [review]
bug1124118.patch

Review of attachment 8552429 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thx Hiro! r=mkmelin

Comment 9

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/f4503d2596a4 -> FIXED