Create a new example similar to annotator that uses new UI components

RESOLVED WONTFIX

Status

Add-on SDK
General
RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: zer0, Assigned: zer0)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Created attachment 8552433 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1838

With widgets gone, we need new examples similar to the previous one.

We could either update the old ones, or create new ones. Because the new UI components are not directly equivalent to the old widgets, I would suggest the latter, also because the previous examples are very, very out dated in term of code.
(Assignee)

Comment 1

3 years ago
Ok, not sure why when I created a new bug, it's automatically added the last attachment I made on another bug. Please, ignore it.
Depends on: 1118364
(Assignee)

Updated

3 years ago
Assignee: nobody → zer0
(Assignee)

Comment 2

3 years ago
Assign it to myself, because I've already updated this example during bug 118364, before split it in multiple bugs.
(Assignee)

Comment 3

3 years ago
Created attachment 8552438 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1839

That is not a re-write from scratch, I have created new icons for the buttons and update the previous code. It could be worthy update or change other part of the example, but that is currently a free-widget version of the previous annotator.
Attachment #8552438 - Flags: review?(evold)
Comment on attachment 8552438 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1839

I think we should remove the example add-ons altogether.

There are a million different ways to promote examples, the tests are examples too, if we really want to include them in our test suite then they can be git submodules for jpm.

Furthermore landing examples like these means we loose valuable developer time maintaining code which doesn't add much value.
Attachment #8552438 - Flags: review?(evold) → review-
I think we should mark this as wontfix.
(Assignee)

Comment 6

3 years ago
It's fine by me. Therefore we want to mark bug 1124164 as wontfix too.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.