1124274 - Do something more constructive on the 500 error page

Status: RESOLVED FIXED

(Webtools Graveyard :: Air Mozilla, defect, P1)

Description

[Peter Bengtsson [:peterbe]]

Attachment: Screenshot 2015-01-21 09.47.17.png

Our 500.html template doesn't help very much. 
Not only could we do something slightly prettier and/or funnier but we can also provide links to bugzilla and IRC.

Comment 1

[Peter Bengtsson [:peterbe]]

Krystal, 
Do you have some good ideas? 

To work on it, it's just a plain HTML page. It can't use the same CSS and javascript and stuff and we can't do any server-side business logic like, for example, Are you logged in or not.

Comment 2

[Sweta Rani]

http://swetarani.github.io/temp/error500

Above is the new view of Error 500 with required links and modifications.
Please see to it and suggest changes(if any) that we require.

Comment 3

[Helena Moreno (aka helenatxu)]

Hi! I'm Helena and I also made a new page for the 500 error. You can find it here http://helenatxu.github.io/500error/index.html

Let me know if you like it or you have any suggestion.

Comment 4

[Sweta Rani]

(In reply to Sweta Rani from comment #2)
> http://swetarani.github.io/temp/error500
> 
> Above is the new view of Error 500 with required links and modifications.
> Please see to it and suggest changes(if any) that we require.

Please see to this pull request: https://github.com/mozilla/airmozilla/pull/226

Comment 5

[Helena Moreno (aka helenatxu)]

Hi @Peter, should I make a pull request like Sweta did?

Comment 6

[Peter Bengtsson [:peterbe]]

Helena, 
I think we talked on IRC about you attacking the bug to do with editing Video Templates, right?
Sorry that there are clashes. But it's the nature of Open Source development and I'm personally making a note of all contribution attempts.

I think Sweta is going with a great start. I've posted lots of feedback on https://github.com/mozilla/airmozilla/pull/226

Comment 7

[Helena Moreno (aka helenatxu)]

Hi Peter! 
I don't know if it wasn't me or I was already gone from IRC (but let my user online) and didn't see you telling me that.
It's okay, when I saw the comment from Sweta I was almost finishing my contribution. I also think that fixing a bug or submitting an improvement should be estimated in terms of improvement, not in terms of who submitted it first ;)
It seems there is another person already working on the task you suggested. Could you asign me or suggest me another task? 
Thank you!

Comment 8

[Peter Bengtsson [:peterbe]]

Helena, 

We when make our application judgement I base it on people making a contribution. Not whose code got merged. Otherwise it would be a race only and that would not be fair. 

I really try my best to get a good insight into all contributions from people independent whose commits get there first. 

Naturally I'm human and I do make oversights and there is a slight benefit in being active on IRC and successfully catching my attention. 

When it's application approval time I collect all my data about who did what. 

Peter

Comment 9

[Helena Moreno (aka helenatxu)]

Great! Thank you Peter for your words :)
So I will take another bug to work on. See you on the IRC!

Helena

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/368ce0015ab1a37d7684abcd395d1f5dc029dc85
fixes bug 1124274 - Error-500 page

https://github.com/mozilla/airmozilla/commit/72bc4e4b1ef003cb9a20aada9a0440c7ab3e3353
Merge pull request #226 from swetarani/bug1124274-Constructive-Error500-page

Bug1124274 constructive error500 page