Open Bug 1124307 Opened 5 years ago Updated 2 years ago

Lock on update and ClassifyLocal so we can run ClassifyLocal on the main thread

Categories

(Toolkit :: Safe Browsing, defect, P5)

All
Linux
defect

Tracking

()

REOPENED

People

(Reporter: mmc, Unassigned)

References

Details

(Keywords: perf, regression, Whiteboard: [talos_regression])

See bug 1122691 comment 26. We need to revert the check to run ClassifyLocal only if tracking protection is enabled to expose any regressions in the phishing/malware case.

+++ This bug was initially created as a clone of Bug #1122691 +++

there is a slight linux32/linux64 tp5o regression as seen here on graph server:
http://graphs.mozilla.org/graph.html#tests=%5B%5B255,131,33%5D%5D&sel=1421091157877.1548,1421411904320.6694,193.54838709677418,361.2903225806452&displayrange=7&datatype=geo

doing some retriggers on tbpl yields:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&fromchange=f19007d9bc01&tochange=af7c46628581&filter-searchStr=Ubuntu%20HW%2012.04%20mozilla-inbound%20talos%20tp5o

this is the change where we went from ~296 -> ~306 (linux32):
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=25d9ba8ceb7a

There are two patches there from two different bugs, I am not sure which one it is.
No longer blocks: 1122690
Component: DOM: Security → Safe Browsing
Product: Core → Toolkit
Priority: -- → P5
See Also: → 1334616
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INACTIVE
Status: RESOLVED → REOPENED
Resolution: INACTIVE → ---
You need to log in before you can comment on or make changes to this bug.