1124357 - alertmanager - when we switch branch/revision, we should regenerate tbplurl

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in alertmanager, we have the ability to change a revision.  Many times we need to switch both the branch and the revision at the same time.  In the case of switching a revision, we should regenerate the tbplurl.  We currently build the tbplurl while ingesting alerts from the newsgroup, here is the code:
https://github.com/jmaher/alert_manager/blob/master/parse_news.py#L247

Ideally we could refactor that out and use it in server.py and parse_news.py.  This type of generation is useful as we get a link to view history and/or retrigger jobs on treeherder- it is a big timesaving device.

Comment 1

[Vikas Mishra [:mishravikas]]

Here's the pr https://github.com/jmaher/alert_manager/pull/127

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

the only piece missing is when we change a revision (without a branch change) that we regenerate the tbplurl.

the pr from comment 1 is merged!

Comment 3

[Vikas Mishra [:mishravikas]]

(In reply to Joel Maher (:jmaher) from comment #2)
> the only piece missing is when we change a revision (without a branch
> change) that we regenerate the tbplurl.
> 
> the pr from comment 1 is merged!

Here's the missing piece https://github.com/jmaher/alert_manager/pull/129