alertmanager - when we switch branch/revision, we should regenerate tbplurl

RESOLVED FIXED

Status

Testing
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jmaher, Assigned: mishravikas)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
in alertmanager, we have the ability to change a revision.  Many times we need to switch both the branch and the revision at the same time.  In the case of switching a revision, we should regenerate the tbplurl.  We currently build the tbplurl while ingesting alerts from the newsgroup, here is the code:
https://github.com/jmaher/alert_manager/blob/master/parse_news.py#L247

Ideally we could refactor that out and use it in server.py and parse_news.py.  This type of generation is useful as we get a link to view history and/or retrigger jobs on treeherder- it is a big timesaving device.
(Reporter)

Updated

3 years ago
Assignee: nobody → vikasmishra95
(Reporter)

Comment 2

3 years ago
the only piece missing is when we change a revision (without a branch change) that we regenerate the tbplurl.

the pr from comment 1 is merged!
(Assignee)

Comment 3

3 years ago
(In reply to Joel Maher (:jmaher) from comment #2)
> the only piece missing is when we change a revision (without a branch
> change) that we regenerate the tbplurl.
> 
> the pr from comment 1 is merged!

Here's the missing piece https://github.com/jmaher/alert_manager/pull/129
(Reporter)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.