1124408 - [e10s] Crash in [ChildView keyDown:] when using password manager

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[David Parks [:handyman]]

This bug is a spinoff of bug 1051842.  It was reported in bug 1051842 comment 103 by Julian Viereck.  The STR from there:

---------------

Using the Firefox Nightly from 20-Jan-2015 I still get crashes: https://crash-stats.mozilla.com/report/index/471bbb0d-9b41-483e-b02d-af4fa2150120

Steps to reproduce:
1. Restart Firefox
2. Go to a page that has a stored password
3. As I have locked my saved passwords via a master password, Firefox prompts me to enter the password
4. In roughly 50% of the cases, after entering the first few characters of my password, the browser crashes

---------------

My sense of this is that the password manager creates a (chrome) popup window and that switching focus to the popup windows fails for IPC reasons that are similar to those in bug 1051842, which were related to OSX window events (raising/lowering/activating/deactivating).  I have not confirmed that.

I do not see this issue in non-e10s windows.

Comment 3

[David Parks [:handyman]]

Just to pile on, I've (not surprisingly) seen this with the Bugzilla addon's password popup as well.

Comment 4

[David Parks [:handyman]]

Renoming since its the #1 mac crash, according to smichaud in bug 1133103 comment 1.

Comment 5

[Mats Palmgren (inactive)]

Filling in the signature field to make this bug known to https://crash-stats.mozilla.com/

Comment 6

[Steven Michaud [:smichaud] (Retired)]

Mats, that won't help.  See bug 1133103 comment #3.

Comment 7

[David Parks [:handyman]]

More reliable STR:

* Activate password manager for bugzilla.mozilla.org
* Open an e10s window
* Navigate to a bug — for example: https://bugzilla.mozilla.org/show_bug.cgi?id=1124408
* Cancel the password manager popup (do not log in)
* Select the search box in the bugzilla page (not the browser’s search box).  Dont type anything.
* Command-Tab away from the browser, then command-tab back
* Press Command-r to reload the page.  The password manager popup will appear again.
* Type a letter.

Expected result:
The letter appears in the password field

Actual result:
CRASH!

Comment 8

[David Parks [:handyman]]

Narrowing it down... another STR:

* Activate password manager for bugzilla.mozilla.org
* Open an e10s window
* Navigate to a bug — for example: https://bugzilla.mozilla.org/show_bug.cgi?id=1124408
* Cancel the password manager popup (do not log in)
* Click a link to another bug (say, one of the duplicates).  When the browser loads the new page, the password manager popup will appear again.
* Type a letter.

Expected result:
The letter appears in the password field

Actual result:
CRASH!

Comment 10

[David Parks [:handyman]]

Attachment: Report cocoa view focus correctly when sheets are exposed

A view should not claim focus if its window has key focus but is also showing a sheet... in that case, the sheet window has focus.  Here, the sheet window is the password popup.

Tests:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ac6b0fac9e9

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8568644 [details] [diff] [review]
Report cocoa view focus correctly when sheets are exposed

Looks good to me. But I want Steven to check this.

Comment 12

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 8568644 [details] [diff] [review]
Report cocoa view focus correctly when sheets are exposed

Looks good to me.  I haven't tested this, but let's see how it plays out.

Comment 13

[David Parks [:handyman]]

Thanks -- I've got high hopes that this is at least why its a top crash.

Tests are here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ac6b0fac9e9

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/50b89dc93750

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/50b89dc93750

Comment 16

[Julian Viereck]

I still get crashes with the latest nightly: https://crash-stats.mozilla.com/report/index/5f846d1b-cff1-455d-86dc-6dd4e2150301. This is when entering the password in the master-password prompt.

Should this bug be reopened?

Comment 17

[Tracy Walker [:tracy]]

I just saw this crash with build (20150302) of Nightly on Mac.  But I can't reliably reproduce it.  I'll keep an eye on it and try to sort out current STR's.  Note: This was only happening to me, prior to the fix, when the browser was on a external (to laptop) monitor.

Comment 18

[David Parks [:handyman]]

The bug here has been fixed (the STRs no longer produce a crash).  However, the crash signature appears for at least one other case.  I'm opening a new bug (bug 1138678) for a new STR that I found while trying to break things.  It may or may not be related to the crashes seen by Julian and Tracy... but its probably the best we can do without STR.