[spam] Add a waffle flag around profile creation

RESOLVED FIXED

Status

developer.mozilla.org
General
--
enhancement
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: hoosteeno, Assigned: mdoglio, Mentored)

Tracking

(Blocks: 1 bug)

Details

(Whiteboard: [patchwelcome][difficulty=intermediate])

In order to minimize the damage of a Worst Case Spam Scenario, we should give admins the ability to quickly halt new profile creation. Can we wrap profile creation in a waffle flag?

The flag should be set to "everyone" during normal site operation. By default, it should be present and set to "everyone" in the dev instance.

If not set to "everyone", nobody will be allowed to create a new profile.
Whiteboard: [patchwelcome][difficulty=intermediate]
Mentor: lcrouch
It would be great if disabling account creation also put up an explanation for new registrants about why. "MDN is under a focused attack by spammers... etc." or something like that. Either a generic message or a one that can be configured when the waffle is enabled.

Updated

3 years ago
Severity: normal → enhancement
(Assignee)

Comment 2

3 years ago
I'll give this bug a try if that's ok
Assignee: nobody → mdoglio
:mdoglio - yeah, thanks! Note: the waffle flag should be something like "disable_registration". I.e., the code should default to letting everyone register profiles, and activating the waffle flag should effectively be a switch to turn it off.

Comment 4

3 years ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/c07b3bae3b84cc3320bbb325e58f8ede9ce4a691
Fix bug 1124419 - add a waffle flag around profile creation

https://github.com/mozilla/kuma/commit/e94460e938813c720bf3744243f3c0b1ac940a6f
bug 1124419 - add feature-toggles.rst

include doc for new registration_disabled flag

https://github.com/mozilla/kuma/commit/a347fa4815502723340ceff8fbbbe69ea291dc14
bug 1124419 - update registration closed copy

https://github.com/mozilla/kuma/commit/d60c88000c4ebd5efb14dd63c68440f3954c3b69
Merge pull request #3091 from groovecoder/waffle-signup-1124419

bug 1124419 - waffle user signup

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
This is merged & pushed. Thanks :mdoglio for all the help! The waffle flag is "registration_disabled".

Comment 6

3 years ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/0449e92dc630e2d704de71213e17928ecafa0eb0
bug 1124419 - fix signup-closed test to new string

https://github.com/mozilla/kuma/commit/c6cdf0a23d836a48c5758d3f30b52ebb4c83081b
Merge pull request #3092 from groovecoder/fix-tests-1124419

bug 1124419 - fix signup-closed test to new string
You need to log in before you can comment on or make changes to this bug.