1124489 - Setup build configuration for Dogfooding

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

Currently, the app name is "Client". This should be changed to "Firefox" (or "Fennec" for developer builds).

Comment 1

[Aaron Raimist [:aaronraimist]]

What should the bundle identifier be? Should it change to Firefox or Fennec?

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This has a good tutuorial on how to have different build flavours with different icons and bundle identifiers through the use of build configurations:

http://nilsou.com/blog/2013/07/29/how-to-have-two-versions-of-the-same-app-on-your-device/

Comment 3

[Brian Nicholson (:bnicholson)]

(In reply to Aaron Raimist [:aaronraimist] from comment #1)
> What should the bundle identifier be? Should it change to Firefox or Fennec?

The bundle identifier will be either "org.mozilla.Fennec" or "org.mozilla.Firefox" depending on the build. These identifiers will be used for the nightly and release builds, respectively.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

> The bundle identifier will be either "org.mozilla.Fennec" or
> "org.mozilla.Firefox" depending on the build. These identifiers will be used
> for the nightly and release builds, respectively.

To non-mozilla people, please DO NOT register these names in Apple's developer console. These are app ids that we want to use.

I'm changing this bug to private to prevent people from seeing this. I'm not behind my Work Mac at the moment so I can't login to the Dev Console so I can't see if we already registered these names or not.

Again, please DO NOT REGISTER these. They need to exist in the Mozilla account only.

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Here is the plan:


THE FOLLOWING TWO ARE FOR DISTRIBUTION:

In the App Store Dev Account:

 * org.mozilla.ios.Firefox - This build will be pushed to the App Store distribution

In the Enterprise Dev Account:

 * com.mozilla.ios.Fennec - This build will be used for dogfooding distribution

(Note the com. ... I think it is a good idea to have our internal enterprise stuff under a different namespace to avoid confusion)


FOR DEVELOPING - MOZILLA DEVS ONLY

Why is this different? Because we use keychain groups, shared storage and ios8 share extensions, you cannot run the app using the wildcard development provisioning profile. (Which is the common way for devs to run on their devices). So, we need a real provisioning profile, and a unique bundle identifier.

 * org.mozilla.ios.Fennec ($DEVNAME)

So, the developer build will show up on your homescreen as for example "Fennec (sarentz)".

The bundle ID will still be the same for every developer, but that is fine.

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

After chatting with :mfinkle

org.mozilla.ios.Firefox - Release Channel (App Store)
org.mozilla.ios.FirefoxBeta - Beta Channel (Most likely Testflight?)
org.mozilla.ios.FennecAurora - Dogfooding Channel (Enterprise Account)
org.mozilla.ios.Fennec - Development (For development via Xcode only*)

*) Note that any registered developer can still build and run the app on their own device. This will require some configuration changes but we can document those to make it easier.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Sounds good to me

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I am changing the title of this bug to simplify things a bit. It is a big task to move this forward because of the complexities of the xcode build system.

So to start this bug will be to change the Release Build Configuration to generate Fennec Aurora builds for dogfooding. (This has been done and will be committed soon)

I will file followup bugs to make similar changes for Development and App Store builds. The first, a Development build, has higher priority so i'll work on that as soon as the Fennec Aurora build changes are committed.

Comment 9

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/138

TL;DR This patch includes a FennecAurora build configuration. This build configuration is used when you Archive a release build. If this is done on a build VM with the Enterprise certificates and provisioning profiles installed, the result is a build on the Fennec Aurora channel.

The changes in this PR are all the result of flipping switches in Xcode. I have done my best to track down these changes in the UI to changes in the project files. They mostly matches, but ... it's complicated.

Comment 10

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Just a quick note that besides the Fennec Aurora build, I can also still successfully run the app in the simulator and on the device.

Comment 11

[Brian Nicholson (:bnicholson)]

Comment on attachment 8560208 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/138

Haven't tried it out, but I'll take your word for it. Thanks for fixing this!

Comment 12

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Merged with one additional commit for which I have no bug. Basically I think something was inconsistent with the project file, which Xcode corrected.

https://github.com/mozilla/firefox-ios/commit/981ef00175780c4dcd75deab5e69c115fbcf516f

Ill leave this open until I get a change to mark all the dependends.