Create an API endpoint for creating reviews in a single request

RESOLVED FIXED

Status

MozReview
General
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: smacleod, Assigned: smacleod)

Tracking

Development/Staging

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Obligatory bug for code review.
(Assignee)

Comment 1

3 years ago
Created attachment 8552793 [details]
MozReview Request: bz://1124502/smacleod

/r/2831 - mozreview: Introduce an API to create reviews in one request (Bug 1124502). r=gps

Pull down this commit:

hg pull review -r 4ac9266a6d6e9b9b5a5862dbb76077a4d734279c
Attachment #8552793 - Flags: review?(mcote)
Attachment #8552793 - Flags: review?(gps)

Comment 2

3 years ago
https://reviewboard.mozilla.org/r/2831/#review2067

This looks good to me. But I'm not an expert on these things. Would appreciate extra RB-aware eyes.

I'm not too thrilled about the naming. Please change that before landing.

::: pylib/mozreview/mozreview/autoreview/resources.py
(Diff revision 1)
> +    name = 'auto_review'

Let's name this "multi review"

::: pylib/mozreview/mozreview/autoreview/resources.py
(Diff revision 1)
> +                diff_comments = json.loads(diff_comments)

Yo dawg, I heard you like JSON in JSON.

Is this limitations in the RB Web API limiting us? I take it we can't make fields arbitrary JS[ON] objects?

Updated

3 years ago
Attachment #8552793 - Flags: review?(gps) → review+

Comment 3

3 years ago
Comment on attachment 8552793 [details]
MozReview Request: bz://1124502/smacleod

https://reviewboard.mozilla.org/r/2829/#review2069

Ship It!
(Assignee)

Comment 4

3 years ago
https://reviewboard.mozilla.org/r/2831/#review2071

> Yo dawg, I heard you like JSON in JSON.
> 
> Is this limitations in the RB Web API limiting us? I take it we can't make fields arbitrary JS[ON] objects?

We're using multi-part form data so it will only be single encoded.
(Assignee)

Comment 5

3 years ago
https://reviewboard.mozilla.org/r/2831/#review2073

> Let's name this "multi review"

As discussed in person, we will go with "batch review"

Comment 6

3 years ago
Comment on attachment 8552793 [details]
MozReview Request: bz://1124502/smacleod

https://reviewboard.mozilla.org/r/2829/#review2075

Ship It!
Attachment #8552793 - Flags: review?(mcote) → review+
(Assignee)

Comment 7

3 years ago
Pushed https://hg.mozilla.org/hgcustom/version-control-tools/rev/c59dab804313
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

3 years ago
Comment on attachment 8552793 [details]
MozReview Request: bz://1124502/smacleod
Attachment #8552793 - Attachment is obsolete: true
Attachment #8619203 - Flags: review+
(Assignee)

Comment 9

3 years ago
Created attachment 8619203 [details]
MozReview Request: mozreview: Introduce an API to create reviews in one request (Bug 1124502). r=gps
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.