1124513 - Breakpoints wrong on prettified youtube source

Status: RESOLVED DUPLICATE of bug 1172931

(DevTools :: Debugger, defect, P1)

Description

[Bobby Holley (:bholley)]

STR:

* Load a youtube video on Nightly
* set breakpoints around the lines that check for YTP_HTML5_NO_AVAILABLE_FORMATS_FALLBACK_FLASH
* Refresh

The debugger stops at a totally different line. To make matters worse, f10 jumps to another seemingly-unrelated function.

This seems pretty bad - this was my only experience using the built-in debugger, and led me to conclude that the debugger is unreliable and doesn't work. I thought it was nightly-only, but sounds like we might be shipping it?

Comment 1

[Shu-yu Guo [:shu]]

Bobby, maybe bug 1124122 is related.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Eddy, can you look into this? I don't think this is a bogus source map, so much as choosing bad offsets to set the BP on. I'm hopeful that your source-mapped BP changes will make this better.

Comment 3

[Bobby Holley (:bholley)]

(In reply to Bobby Holley (Busy with media, don't ask for DOM/JS/XPConnect things) from comment #0)
> * set breakpoints around the lines that check for
> YTP_HTML5_NO_AVAILABLE_FORMATS_FALLBACK_FLASH

specifically, in html5player.js.

Comment 4

[Eddy Bruel [:ejpbruel]]

I'll look into this.

Comment 5

[Eddy Bruel [:ejpbruel]]

Marking this as P1 as it is one of those issues that make the debugger unusable for people.

Comment 6

[Mike Taylor [:miketaylr]]

I guess this is a dupe of https://bugzilla.mozilla.org/show_bug.cgi?id=1172931 (or vice-versa). This one came first, but the other one is linked to meta bugs.

Also, this bug makes me sad. ;------;