Closed Bug 1124514 Opened 9 years ago Closed 9 years ago

Reader mode not available on www.dromble.com

Categories

(Firefox for iOS :: Reader View, defect)

Product:
Firefox for iOS
Component:
Reader View
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: st3fan, Unassigned)

References

Details

http://www.dromble.com/2015/01/21/former-nintendo-executive-dan-adelman-discusses-nintendos-culture-third-party-support-and-much-more/

Works on Android, not on iOS.

I don't see a reason why we would fail here. The only odd thing that I noticed is that the page throws a JS error.

Does this mean that our injected user scripts are not executed if the page has an error?
The error on that page is:

[Error] SyntaxError: Unexpected identifier 'DefVid'. Expected ';' after var declaration.
	write (former-nintendo-executive-dan-adelman-discusses-nintendos-culture-third-party-support-and-much-more, line 1)
	z (fcmdynet.js, line 12)
	Z (fcmdynet.js, line 12)
	loadL3 (former-nintendo-executive-dan-adelman-discusses-nintendos-culture-third-party-support-and-much-more, line 1)
	apply ([native code], line 0)
	execSafe (nmedianet.js, line 1)
	W (nmedianet.js, line 1)
	(anonymous function) (fcmdynet.js, line 12)
	execSafe (nmedianet.js, line 1)
	W (nmedianet.js, line 1)
	processL3 (former-nintendo-executive-dan-adelman-discusses-nintendos-culture-third-party-support-and-much-more, line 1)
	onreadystatechange (former-nintendo-executive-dan-adelman-discusses-nintendos-culture-third-party-support-and-much-more, line 1)

This is likely useless info. What we should do is test the hypothesis that an error will abort processing our injected scripts.
> This is likely useless info. What we should do is test the hypothesis that an error will abort processing our injected scripts.

Nope. Other pages on that site have the same error and still show the reader mode button.
Calling _firefox_ReaderMode.checkReadability() results in

[Error] Failed to load resource: the server responded with a status of 404 (Not Found) (LuckySeymoreBGFB-300x93.jpg, line 0)

Not sure why that would trigger an image load. Is that the cause of Readability completely failing?
Moved to https://github.com/mozilla/readability/issues/74 .. we do not block on bugs like this.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.