1124543 - Graphical glitch during animation

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Alice0775 White]

Attachment: screenshot during animarion

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:

+++ This bug was initially created as a clone of Bug #1123522 +++

I can notice a different glitch from the video(Bug 1123522 attachment 8552787 [details]) on Linux and Windows.
I am not sure this is a same cause or not.
So, I filed a new bug anyway.

Steps to reproduce:
1. Modified js according to Bug 1123522 comment#0
2. Open index.html

Actual results:
See attached screenshot

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2a61df4eaa2d&tochange=24ba8274ed60

In local build(win32 non pgo)
Last Good: 2a61df4eaa2d
First Bad: 823227372483

Regressed by 823227372483	Bas Schouten — Bug 1107297: Only recomposite the damaged rect with D3D11. r=jrmuizel

Comment 1

[Alice0775 White]

Attachment: test.zip (Modified one)

Comment 2

[Alice0775 White]

When disabled HWA, the regression window is different.

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=06b540d3667a&tochange=912c96edb352

Regressed by Bug 1039926

Comment 3

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 4

[Bas Schouten (:bas.schouten)]

This is a bug in layout incorrectly reporting the damaged rect to the layer manager.

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Matt - Can you take this bug?

Comment 6

[Matt Woodrow (:mattwoodrow)]

Attachment: mask-invalidation

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8555629 [details] [diff] [review]
mask-invalidation

Review of attachment 8555629 [details] [diff] [review]:
-----------------------------------------------------------------

Test?

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Matt, could you land this asap? I would like to have the fix in beta 7 (gtb next Thursday).
Thanks

Comment 9

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6df246c641de

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6df246c641de

Comment 11

[Sylvestre Ledru [:Sylvestre]]

thanks :)
could you fill the uplift request? thanks

Comment 12

[Alice0775 White]

I can still reproduce the problem with/without HWA on the following m-i tinderbox-build.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6df246c641de
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0 ID:20150203134025

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Like 35, it seems that 36 is going to ship it this bug. Wontfix then.

Comment 14

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8555629 [details] [diff] [review]
mask-invalidation

Approval Request Comment
[Feature/regressing bug #]: Bug 1107297
[User impact if declined]: Fixes at least one cause of this bug, possibly not al of them as per comment 12.
[Describe test coverage new/current, TreeHerder]: Tested manually.
[Risks and why]: Very low risk, just an invalidation change
[String/UUID change made/needed]: None.

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8555629 [details] [diff] [review]
mask-invalidation

Too late in the beta cycle and we already released 35 with this bug.
Let it ride the train with 37

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0c58c1cc9ae7

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Matt, I think we should close this out and move comment 12 to a new bug. The uplift is Monday and tracking's going to be a pain otherwise.

Comment 18

[Alice0775 White]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #17)
> Matt, I think we should close this out and move comment 12 to a new bug. The
> uplift is Monday and tracking's going to be a pain otherwise.

I've filed new Bug 1140362.