1124552 - Firefox Search inconsistently responds to clicking the plus icon

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Dan]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141125180439

Steps to reproduce:

1. Open search.
2. Type "search"
3. Click plus icon next to "search engines"
---
4. Hit android back
5. Clear Search
---
6. Type "search"
7. Click plus icon next to "search by image"



Actual results:

Step 3 executes a search for "search engine"
Step 7 populates the search field with "search by image" and allows you to edit further


Expected results:

Steps 3 and 7 should behave the same.  No rationale is obvious for why one results in an immediate search, and the other allows further editing.  The plus is presumably meant to have similar behavior to the diagonal arrow for editing a previous search that Google uses, but it does not behave exactly the same as Google's, or even consistently.

Further, the home screen, before typing anything, shows previous searches, which can be executed or removed.  But there is no way to edit them (again, unlike Google's).  You must first execute them, then edit.  This takes us back to how Google behaved in Android 2.1 (they quickly realized what a poor experience that was and fixed it).

Comment 1

[Dan]

After further review, this seems to just be a small clickable area for the plus icon.  If I use my pinky carefully I can get consistent results.  I'm not sure why I consistently missed the icon for the first line, but perhaps it has to do with the position on my screen.

Comment 2

[Aaron Train [:aaronmt]]

Assuming this was tested against release (Firefox 35) on Google Play from comment #0. Testing on Firefox 36->38, I'm unable to reproduce which leads me to believe that this behaviour was adjusted on newer branches. Margaret, do you know what might have corrected this?

Comment 3

[:Margaret Leibovic]

(In reply to Aaron Train [:aaronmt] from comment #2)
> Assuming this was tested against release (Firefox 35) on Google Play from
> comment #0. Testing on Firefox 36->38, I'm unable to reproduce which leads
> me to believe that this behaviour was adjusted on newer branches. Margaret,
> do you know what might have corrected this?

It looks like this logic last changed in bug 1046485, but that landed back in Firefox 34.

From comment 1, it sounds like we may have made the tap area for that + icon too small. We can look into increasing that.

Comment 4

[Jan Henning [:JanH]]

This is an ex-Search Activity now (bug 1221344).