[Cost control] Add a flag for activating/deactivating the customize mode

RESOLVED FIXED

Status

Firefox OS
Gaia::Cost Control
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mai, Assigned: mai)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
salva
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Adding a flag to provide a way of landing step by step the new funcionality of 'customize/prepaid mode'.
This way when the code is finished and tested, the functionality could be landed on a easy way.
(Assignee)

Updated

3 years ago
Assignee: nobody → marina.rodrigueziglesias
(Assignee)

Comment 1

3 years ago
Created attachment 8553096 [details] [review]
patch v1.0

Hi Salva,
would you mind reviewing the patch?
Regards
Attachment #8553096 - Flags: review?(salva)
(Assignee)

Updated

3 years ago
Summary: [Cost control] Add a flag for actívating/deactivating the customize mode → [Cost control] Add a flag for activating/deactivating the customize mode
Comment on attachment 8553096 [details] [review]
patch v1.0

Let's use a property of `ConfigManager` as flag instead of a new program option. This way, no extra async queries introduced.
Attachment #8553096 - Flags: review?(salva)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8553096 [details] [review]
patch v1.0

Updatd the pr with your comments
Attachment #8553096 - Flags: review?(salva)
Comment on attachment 8553096 [details] [review]
patch v1.0

You have a couple of comments on GitHub. r+ when they are done. Thank you, Mai.
Attachment #8553096 - Flags: review?(salva) → review+
(Assignee)

Comment 5

3 years ago
Master: d8ce5f3c9f7c67a8852e5750badcfd29d228d6e2
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.